All the accessibility issues that were stable blockers have been addressed.

This issue is meta issue to track know accessibility issues that affect Settings Tray. Most of these issues aren't actually in the Settings Tray module itself.

Original summary

This issue is to keep track of accessibility issues related to the Settings Tray module and to determine which ones need to resolved before the module is mark stable. Some issues are not within Settings Tray itself but with the Off-canvas library (which was added for Settings Tray originally), while other issues are existing issues with contextual links and/or the core dialog system.

Must-have: Off-canvas dialog

  1. All fixed!!1

Should-have: Settings Tray

  1. Any other issues surfaced in #2919837: Accessibility Issues with Off-Canvas dialog that are not already covered in the rest of the list.

Should-have: Contextual Module

  1. #2915762: Return to tab position when exiting dialog opened from contextual link

Should-have: Offcanvas library

Nice-to-have

Already fixed

Comments

tedbow created an issue. See original summary.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Related issues: +#2773601: Display "You are now in edit mode" prompt when user enters edit mode, +#2784569: Settings Tray Accessibility: Improve tabbing, +#2919837: Accessibility Issues with Off-Canvas dialog, +#2915759: :focus is is hard to see for links in the off-canvas dialog, +#2915762: Return to tab position when exiting dialog opened from contextual link, +#2919147: When edit mode is enabled new page loads will not have Contextual tabbing constrained

Adding related issues

Also Just postponed #2773601-71: Display "You are now in edit mode" prompt when user enters edit mode based on the fact that it would be much better to do after #77245: Provide a common API for displaying JavaScript messages(which just got RTBC).

#2773601-71: Display "You are now in edit mode" prompt when user enters edit mode I detailed the reasons that I hope this doesn't stop Settings Tray from getting stable.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue tags: +Needs accessibility review
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Removing #2773601: Display "You are now in edit mode" prompt when user enters edit mode because it was only a UX hard require in the original issue #2762505: Introduce "outside in" quick edit pattern to core

Review this with UX meeting an all agreed the message doesn't had much over the visual clues that elements on the page are clickable.

From accessibility Drupal.announce() is still used when you to into edit mode similar to contextual module.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

Updating the summary separating must-haves from should-haves (based on my review of #2919837: Accessibility Issues with Off-Canvas dialog).

Thanks everyone!

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes

I posted #2934499: Adjust foccus styling for the Settings Tray [x] close button to match the dialog system, which is postponed on #2863354: Add border to dialog [x] close button for hover and focus states.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Moving 2 items to already fixed 🎉

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Moved the wrong item

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Updating to show #2934499: Adjust foccus styling for the Settings Tray [x] close button to match the dialog system is no longer postponed

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

#2934178: Contrast issues with off-canvas dialog styling fixed! Last most have for this issue!!!!!

I leave this open for so we can track the remaining should haves.

But will update #2922603: Mark Settings Tray module as stable that this is no longer a blocker for stable!!!!!

#2934499: Adjust foccus styling for the Settings Tray [x] close button to match the dialog system also fixed!

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Issue summary: View changes

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: [META] Accessibility review for marking Settings Tray as stable » [META] Accessibility issues for Settings Tray
Issue summary: View changes

Updating to change to just track accessibility issue. No more issues blocking stable

andrewmacpherson’s picture

andrewmacpherson commented
Issue summary: View changes

We've started implementing #2928103: [policy, no patch] Use "prefers-reduced-motion" media query to disable animations.

We already have a proof-of-concept patch to turn off animation for the batch progress bar. It would be good to open a new issue for the settings tray animation. This is for a WCAG 2.1 "Animations from interactions", a new one coming in at level AAA. It isn't a must-have for our accessibility gate, but it looks like an easy win.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#2928103: [policy, no patch] Use "prefers-reduced-motion" media query to disable animations
andrewmacpherson’s picture

andrewmacpherson commented
Issue summary: View changes

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

smustgrave’s picture

smustgrave commented

Been 8 years should this be closed? Since must haves are fixed

cosmicdreams’s picture

cosmicdreams commented
Status: Active » Fixed

agreed. We can start anew with a fresh ticket.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.