Problem/Motivation

webchick added in #2927230-12: 3/3 JS codestyle: camelcase a deprecation message pointing to 8.0.0, it should point to 8.5.0

* @deprecated in Drupal 8.0.0 and will be removed before Drupal 9.0.0.
+     * Use elementSettings.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2928137-1.patch446 bytesblakemorgan

Comments

dawehner created an issue. See original summary.

blakemorgan’s picture

blakemorgan commented
Assigned: Unassigned » blakemorgan
blakemorgan’s picture

blakemorgan commented
Status: Active » Closed (works as designed)

Since this was deprecated in Drupal 8.0.0, the message is correct. If it was current up to 8.5.0 then deprecated, then the message would need to say 8.5.0.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Closed (works as designed) » Active

How could this possibly have been deprecated as of 8.0.0 when the patch that added the deprecation was literally committed yesterday? :) We just need to change it to say 8.5.0 (it was a typo or copypaste error).

blakemorgan’s picture

blakemorgan commented
StatusFileSize
new 2928137-1.patch446 bytes
blakemorgan’s picture

blakemorgan commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed 017e42e and pushed to 8.5.x. Thanks!

  • lauriii committed 017e42e on 8.5.x 
    Issue #2928137 by blakemorgan, dawehner: Correct deprecation note in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.