I agreed with @andypost about split this issue, therefore I create this issue for fix code style by drupal standards.

CommentFileSizeAuthor
#7 2927589-fix-code-style-7.patch26.57 KBvpeltot
#2 2927589-fix-code-style-2.patch30.1 KBr.nabiullin

Comments

nabiyllin created an issue. See original summary.

r.nabiullin’s picture

r.nabiullin commented
StatusFileSize
new 2927589-fix-code-style-2.patch30.1 KB
r.nabiullin’s picture

r.nabiullin commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2927589-fix-code-style-2.patch, failed testing. View results

ivan berezhnov’s picture

ivan berezhnov commented
Issue tags: +CSKyiv18
pguillard’s picture

pguillard commented

Everything seems correct in this patch, we have non-related test errors.

vpeltot’s picture

vpeltot commented
Status: Needs work » Needs review
StatusFileSize
new 2927589-fix-code-style-7.patch26.57 KB

Here a new patch after #2706639: Support for sub-entity cloning is fixed

pguillard’s picture

pguillard commented
Status: Needs review » Reviewed & tested by the community

PHPCS gives no errors

vpeltot’s picture

vpeltot commented
Status: Reviewed & tested by the community » Closed (duplicate)

Duplicate #3023831: Drupal standards
A new issue was created and a new patch was submitted regarding the new version of code.