Suggested commit message

git commit -m 'Issue #2927569 by amateescu, tstoeckler: Various tests do not set values for required field when creating entities'

Problem/Motivation

Various tests create entities without setting required fields. #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field will break all those tests, but it makes sense to adapt them in their own right for correctness' sake.

Proposed resolution

Do it!

CommentFileSizeAuthor
#2 2927569-2.patch19.68 KBtstoeckler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

Status: Active » Needs review
FileSize
19.68 KB

Here we go.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

This seems simple enough.

jibran’s picture

amateescu’s picture

tstoeckler’s picture

Issue summary: View changes

Adding a suggested commit message, thanks for pointing that out. Again, if I forgot someone please amend.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2927569-2.patch, failed testing. View results

tstoeckler’s picture

Status: Needs work » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2927569-2.patch, failed testing. View results

amateescu’s picture

Status: Needs work » Reviewed & tested by the community

Testbot fluke..

larowlan’s picture

Adding @amateescu to review credits as per #2

  • larowlan committed 7d1545b on 8.5.x
    Issue #2927569 by tstoeckler, amateescu: Various tests do not set values...

  • larowlan committed 4596e95 on 8.4.x
    Issue #2927569 by tstoeckler, amateescu: Various tests do not set values...
larowlan’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 7d1545b and pushed to 8.5.x.
Cherry picked as 4596e95 and pushed to 8.4.x

Unpostponied the stuff stuck on this

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.