Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Suggested commit message
git commit -m 'Issue #2927569 by amateescu, tstoeckler: Various tests do not set values for required field when creating entities'
Problem/Motivation
Various tests create entities without setting required fields. #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field will break all those tests, but it makes sense to adapt them in their own right for correctness' sake.
Proposed resolution
Do it!
Comment | File | Size | Author |
---|---|---|---|
#2 | 2927569-2.patch | 19.68 KB | tstoeckler |
Comments
Comment #2
tstoecklerHere we go.
Comment #3
jibranThis seems simple enough.
Comment #4
jibranThis is major as it is blocking #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field.
Comment #5
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThe comment from #2927563-5: Aggregator feed "refresh" field should have a default value also applies here :)
Comment #6
tstoecklerAdding a suggested commit message, thanks for pointing that out. Again, if I forgot someone please amend.
Comment #8
tstoecklerComment #10
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedTestbot fluke..
Comment #11
larowlanAdding @amateescu to review credits as per #2
Comment #14
larowlanCommitted 7d1545b and pushed to 8.5.x.
Cherry picked as 4596e95 and pushed to 8.4.x
Unpostponied the stuff stuck on this