Currently the ActivityFactory has a lot of private methods. This makes extending the class very difficult because each private method will need to be reimplemented in an inheriting class. This leads to code duplication, hard maintenance and eventually bugs.

We already have an internal use-case for extending this class in the social_renamer module. I don't see a good reason to keep any of the methods private.

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

Attached is the patch to make the change.

Pull request at https://github.com/goalgorilla/open_social/pull/653

kingdutch’s picture

Assigned: kingdutch » Unassigned
Status: Active » Needs review

Forgot to unassign and change status.

jaapjan’s picture

Status: Needs review » Fixed

Reviewed and merged.

  • Kingdutch committed 2ca43fe on 8.x-1.x
    Issue #2927417 by Kingdutch: Change visibility of ActivityFactory...
  • c073140 committed on 8.x-1.x
    Issue #2927417 by Kingdutch: Change visibility of ActivityFactory...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.