If you have enabled Adminimal Administration Menu then you sure get broken admin pages as mentioned in title.

Just notifying here to avoid multiple issues creation like ... not working.

CommentFileSizeAuthor
#23 advagg-2927301-22-2-jquery-holdready.patch1.16 KBmikeytown2
#16 advagg-2927301-15-holdready-mutiple-jquery-versions-fix.patch1.86 KBmikeytown2
#14 advagg-2927301-14-holdready-mutiple-jquery-versions-fix.patch1.68 KBmikeytown2
#10 Archive 17-12-01 15-42-09(modules-page-bundler-enabled)-worked.har_.zip364.3 KBnithinkolekar
#10 Archive 17-12-01 15-42-09(modules-page-bundler-enabled)-NOT-working.har_.zip201.57 KBnithinkolekar
#6 Archive 17-11-30 20-17-23(views-page-aft-patch-#2407007-23).har_.zip304.8 KBnithinkolekar
#3 #2927301-2-instant-filter-(modules-page).png65.26 KBnithinkolekar
#3 Archive 17-11-30 10-59-07(modules-page).har_.zip298.61 KBnithinkolekar
#3 #2927301-1-views-admin-page.png87.71 KBnithinkolekar
#3 Archive 17-11-30 10-49-17(views-admin).har_.zip307.2 KBnithinkolekar

Comments

nithinkolekar created an issue. See original summary.

mikeytown2’s picture

mikeytown2 commented
Category: Task » Support request

Can I get a HAR or zip of the page in question?

nithinkolekar’s picture

nithinkolekar commented
StatusFileSize
new Archive 17-11-30 10-49-17(views-admin).har_.zip307.2 KB
new #2927301-1-views-admin-page.png87.71 KB
new Archive 17-11-30 10-59-07(modules-page).har_.zip298.61 KB
new #2927301-2-instant-filter-(modules-page).png65.26 KB

Har from firefox v56.0.2 and archived to zip format.

advagg is configured as exactly as https://groups.drupal.org/node/517292

any additional info needed? let me know

mikeytown2’s picture

mikeytown2 commented

Go to the status report page admin/reports/status and fix the advagg issues that it will complain about. Aggregation is currently disabled so advagg isn't doing much and in this case it can't hotfix the jquery-no-conflict.slicknav.js file (#2907586-12: Adminimal Administration Menu breaks display for Deferred JavaScript Execution option). You can also apply this patch as it does the same fix #2407007-23: Uncaught TypeError when using with Media.

mikeytown2’s picture

mikeytown2 commented

I should probably set a message at the top of the advagg admin pages if core aggregation is turned off; might want to pull in some of the simpler checks that happen on the status report page as well; or point the user towards that if this issue is found.

nithinkolekar’s picture

nithinkolekar commented
StatusFileSize
new Archive 17-11-30 20-17-23(views-page-aft-patch-#2407007-23).har_.zip304.8 KB

after clearing all advagg issues mentioned on status report ,Smart Cache Flushed but still pages are broken and admin menu is missing too. Error about Drupal.admin at console is fixed though.

attaching the har of views page after patch is applied.

mikeytown2’s picture

mikeytown2 commented

I can't find the problem from the har file. I'd start by disabling the changes done on the advagg modifications page; that usually causes the most issues. Let me know which change brought back the admin bar for you.

nithinkolekar’s picture

nithinkolekar commented

got it ;)
after disabling Target Number Of CSS Bundles Per Page and Target Number Of JS Bundles Per Page it is now working.(Both were set to 15)

mikeytown2’s picture

mikeytown2 commented

Can you provide another har of the site with the admin bar working? If changing the bundle size fixes it, that usually indicates there's another issue (bundle size is not the root cause).

nithinkolekar’s picture

nithinkolekar commented
StatusFileSize
new Archive 17-12-01 15-42-09(modules-page-bundler-enabled)-NOT-working.har_.zip201.57 KB
new Archive 17-12-01 15-42-09(modules-page-bundler-enabled)-worked.har_.zip364.3 KB

attaching both working and buggy har for modules page. Each file is created by clearing Smart Cache Flushed,flush full cache and shift+reload page to down load files freshly. You can notice that there is a big size difference between both file for the same page , that might help you.

can #2917231: More logging? help for this?

erku’s picture

erku commented
Issue tags: +broken admin pages with advagg, +rich text buttons don't show with advagg

Hello, is there a solution on this? I have two sites. One works perfectly, the other doesn't. And I Have no idea why. Both are the same theme, and drupal 7. On the website that it doesn't work admin area is not showing and when I try to publish a story the rich text buttons don't show at all. Any help or suggestion please?

mikeytown2’s picture

mikeytown2 commented

Looks like it could be an issue with $jQueryAdminimal not being available. Looking more into it. Thanks for the 2 har files; that was very helpful!

mikeytown2’s picture

mikeytown2 commented
Title: broken admin pages(views,fieldset,instant filter). cause conflicting with Adminimal Administration Menu » 2 jQuery versions loaded on a singe page and defer is enabled; jQuery.holdReady never gets released with second jquery inclusion if split over multiple files
Category: Support request » Bug report

Pretty good edge case here. Working on a fix.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new advagg-2927301-14-holdready-mutiple-jquery-versions-fix.patch1.68 KB

  • mikeytown2 committed 676110e on 7.x-2.x 
    Issue #2927301 by mikeytown2, nithinkolekar: 2 jQuery versions loaded on...
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed
StatusFileSize
new advagg-2927301-15-holdready-mutiple-jquery-versions-fix.patch1.86 KB

holdReady is trickier than it looks; this is the patch that was committed.

nithinkolekar’s picture

nithinkolekar commented

Thnx for committing
for debugging this kind of issue and because module itself is very big and highly configurable

One small feature request like
Global Radio button
Preset 1- some set of enabled options
Preset 2- more set of additional options etc. With some logical relation

This way we switch between preset and identify the cause.

mikeytown2’s picture

mikeytown2 commented

Did the fix in #16 work for you?

Having a UI to do that wouldn't be easy. I'm open to patches (in this case it should be a new sub module) but I will not be creating it (don't have the time). The readme says that "AdvAgg Modifier are usually the most problematic" and to "make sure the change didn't mess up your site". There is a reason AdvAgg has some of the recommended settings off by default, it's the safest configuration and/or its how core works. It would be nice to have better defaults but they can cause issues; my hope is that the admin knows what settings were recently done and therefore knows what setting caused the issue and can then report the bugs so they get fixed.

nithinkolekar’s picture

nithinkolekar commented

:( bug returns..

because you had committed code without RTBC I thought you were sure about it and I neglected to check bundler configuration which was disabled earlier for #10.

When I re-enabled it then same thing happened. This time I checked by changing Target Number Of CSS Bundles Per Page
and Target Number Of JS Bundles Per Page for each value and found that, for CSS there is not an issue for 1 to 15 but when JS item >2 then this bug triggers.

CSS {any value 0 to 15} and JS {0-2} No problem everything works.
CSS{any value 0 to 15} and JS { 3 and above } bug triggers.

For time being having JS set to 2.

mikeytown2’s picture

mikeytown2 commented
Status: Fixed » Active

There could be more than 1 issue here. Can I get another har file with the page broken? I had it working locally with your har file but something must not be accounted for

nithinkolekar’s picture

nithinkolekar commented

Give me some time to watchdog JS filename to which error is triggering.
Will upload har file along with that info..

  • mikeytown2 committed a66df6e on 7.x-2.x 
    Issue #2927301 by mikeytown2, nithinkolekar: 2 jQuery versions loaded on...
mikeytown2’s picture

mikeytown2 commented
Status: Active » Fixed
StatusFileSize
new advagg-2927301-22-2-jquery-holdready.patch1.16 KB

Was able to reproduce this locally. Think this will fix it, but will keep previous fix in place as that did help; seems to be jQuery version dependent.

nithinkolekar’s picture

nithinkolekar commented

sorry for not responding your request as I was busy with d3js issues.

patch #23 worked fine.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.