No index is added for the target_id_int column

I started to create a test for the update hook, however, I realized a new data snapshot would need to be generated after dynamic_entity_reference_update_8201 was run. The reason is the DER fields in the current snapshot do not have a target_id_int column in the database. Once dynamic_entity_reference_update_8201 is run, the field is added and the fix in this patch works as expected by adding an index on the new column. However, it prevents us from doing an isolated test to confirm that the update hook in this patch works as expected and creates the index on any existing DER fields that already have the target_id_int column.

I'm also not sure about all the test cases that need to covered for this change. But I thought I would at least provide the solution I have so far.

Thanks, for working on this. We need tests for this change and we also need upgrade path tests for this.

+++ b/dynamic_entity_reference.install
@@ -123,3 +123,62 @@ function dynamic_entity_reference_update_8201() {
+          $spec = [
+            'fields' => [
+              $column => [
+                'type' => 'int',
+                'unsigned' => TRUE,
+                'not null' => FALSE,
+              ],
+              $index_column => $schema_info['columns']['target_type']
+            ]
+          ];

Can we please move the static part of this array outside the loops?

+++ b/tests/src/Functional/Update/DerUpdate8202Test.php
@@ -0,0 +1,52 @@
+ * Tests DER update path from 8201 and on.

Thanks, for this comment. Should we add assert in 8201 tests as well?

Can you please share the DB generation script as well?

Thanks, I'll have a look at FieldStorageSubscriber in detail after these changes and commit it.

.

I reviewed the changes thank you @nick.james and @jhedstrom for finding and fixing this. Committed and pushed to 8.x-2.x. Fixed following CS issues on commit. I'll create a new release soon.