Since upgrading to 8.4.2 I have started getting errors in the console.

Uncaught TypeError: Cannot set property 'position' of undefined
    at position-min.js?v=1.12.1:4

It only seems to occur in the Frontend theme, not when viewing the Seven admin theme. I've tested with my custom theme as well as Stark and Bartik and still get the same issue. It only occurs when logged in. I managed to make the error disappear by removing all admin toolbar modules and the core toolbar module.

Has anyone else encountered this?

CommentFileSizeAuthor
#4 2925997-4.patch401 bytestikaszvince

Comments

ndolley created an issue. See original summary.

dtraft’s picture

I am also having this issue!

In my case, we have a limited admin toolbar for site editors and the error only occurs for them - it appears to work fine for site admins.

codesmith’s picture

I have a custom theme and am getting this error when *not* logged in.

tikaszvince’s picture

StatusFileSize
new401 bytes

The code of assets/vendor/jquery.ui/ui/position-min.js depends on core/jquery.ui library, but the library definition of jquery.ui.position does not mark this dependency. So when other library depends on core/jquery.ui.position(i.e. quickedit) they have to depends on core/jquery.ui too.

The attached patch set core/jquery.ui as dependency for jquery.ui.position library.

tikaszvince’s picture

Status: Active » Needs review
joelpittet’s picture

Status: Needs review » Reviewed & tested by the community

Nice catch, thanks @tikaszvince for the patch and @ndolley for the issue

codesmith’s picture

Patch in #4 fixes the issue for me. Thank you @tikaszvince!

larowlan’s picture

Version: 8.4.x-dev » 8.5.x-dev

8.4.x will only receive critical backports now

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

catch’s picture

Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed d2767fd on 8.6.x
    Issue #2925997 by tikaszvince, ndolley: position-min.js issue since 8.4...

  • catch committed 29d131c on 8.5.x
    Issue #2925997 by tikaszvince, ndolley: position-min.js issue since 8.4...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.