Problem/Motivation

Every time we add new things to validate and test it using config_test.validate we're changing \Drupal\config_test\ConfigValidation::validateMapping(). See #2920682: Add config validation for plugin IDs and #2920678: Add config validation for the allowed characters of machine names

This is a test only change.

Proposed resolution

Make the validation less brittle to change.

This was added in #1928868-102: Typed config incorrectly implements Typed Data interfaces - the comment that lead to test was:

So we currently do not validate an entire mapping or sequence on its own.

So this change is still ensuring that we are looking at all the keys in the mapping.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 2925689-3.patch1.87 KBalexpott
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott’s picture

Issue summary: View changes
Status: Active » Needs review
Related issues: +#1928868: Typed config incorrectly implements Typed Data interfaces
FileSize
1.87 KB

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Nice litte fix! Thank you alex

  • catch committed 68b8b52 on 8.6.x
    Issue #2925689 by alexpott: ConfigValidation class contains code that is...
catch’s picture

Version: 8.6.x-dev » 8.5.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!

  • catch committed 3dff0e5 on 8.5.x
    Issue #2925689 by alexpott: ConfigValidation class contains code that is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.