Problem/Motivation

StylePluginBase has a wizardForm() method that is never called.

Proposed resolution

Deprecate the method

CommentFileSizeAuthor
#15 interdiff_7-15.txt1.16 KBraman.b
#15 2925612-15.patch993 bytesraman.b
#10 unused--function.jpg112.27 KBranjith_kumar_k_u
#7 2925612-7.patch962 bytess_bhandari

Comments

tstoeckler created an issue. See original summary.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

s_bhandari’s picture

s_bhandari commented
Assigned: Unassigned » s_bhandari
Status: Active » Needs work
StatusFileSize
new 2925612-7.patch962 bytes

Added a patch for the same.

s_bhandari’s picture

s_bhandari commented
Assigned: s_bhandari » Unassigned
Status: Needs work » Needs review

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
StatusFileSize
new unused--function.jpg112.27 KB

The above patch applied cleanly ,it removes the following unused function from core/modules/views/src/Plugin/views/style/StylePluginBase.php.
unused function

ranjith_kumar_k_u’s picture

ranjith_kumar_k_u commented
Status: Needs review » Reviewed & tested by the community
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Bug Smash Initiative

This was last touched in #2002928: Rename Views method wizard_form() to wizardForm() where it was argued to keep it, but 7 years later and I don't see how this is ever called, so I think it's time for it to go.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Category: Bug report » Task

The call to this (ok it's D7 form) was added in #1185042: Have style plugin add additional fields to the wizard when the style is chosen

And then removed the next day in #1747810: Move wizard-specific meta-information from plugin annotation to a class property

+++ b/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php
@@ -314,7 +422,6 @@ abstract class WizardPluginBase implements WizardInterface {
-    $style_plugin->wizard_form($form, $form_state, $type);

so this can go.

But I'd call this a task.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice

While this looks like properly dead code, given it's on a base class I think we should deprecate it for 10.0.x removal (but skip test coverage for that, just the phpdoc and trigger_error() + change record is plenty here).

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
StatusFileSize
new 2925612-15.patch993 bytes
new interdiff_7-15.txt1.16 KB

Created CR, added phpdoc and trigger_error()

https://www.drupal.org/node/3186502

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

quietone’s picture

quietone commented
Issue summary: View changes

  • catch committed 2ca6302 on 9.2.x 
    Issue #2925612 by raman.b, S_Bhandari, ranjith_kumar_k_u, tstoeckler,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 2ca6302 and pushed to 9.2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.