Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#1 views-rename-methods-2002928-1.patch649 bytesbdone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Active » Needs review
FileSize
views-rename-methods-2002928-1.patch649 bytes
marlatt’s picture

marlatt CreditAttribution: marlatt commented
Status: Needs review » Reviewed & tested by the community

Confirmed no instances of old method remaining and contains public method assignment.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Needs work

Can't work out how this function would be called - is it necessary?

bdone’s picture

bdone CreditAttribution: bdone commented

@alexpott: while core isn't yet, i believe StylePluginBase could potentially be used by contrib plugins that extend it.

perhaps someone from VDC can confirm that?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Reviewed & tested by the community

By default the fields generated by the wizard will have no label, as it just looks silly.

The table style plugin removes that in the wizardSubmit method to show a label in the table header. That's just one
example why style plugins want to interfere with the wizard, so I would personally vote for keeping it in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed b2d4053 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.