Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2017 at 19:32 UTC
Updated:
7 Dec 2017 at 18:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
zaporylieThis patch extracts from #2909372-12: Enable 'Drupal.Commenting.VariableComment.MissingVar' coding standard missing @var annotations for scalars that provide default value.
Comment #3
martin107 commented@zaporylie
Thanks for putting all the work into fixing this and other issues
zaporylie++
The patch still applies.
After a visual inspection of the patch ....Yep all these changes look good to me.
Comment #5
xjmChecked those over; it's easy to see that the correct data type is given in each case and that they're unlikely to allow a different data type (or NULL since they're being initialized to other things).
I opened the file to check this one since it was beyond the context lines:
protected $profile = 'minimal';So that's correct too.
Committed to 8.5.x, and cherry-picked to 8.4.x as a pure docs improvement. Thanks!