See #2909372-14: Enable 'Drupal.Commenting.VariableComment.MissingVar' coding standard for the reason why this child issue was created and #2909364: [meta] Fix 'Drupal.Commenting.VariableComment' coding standard for general instructions about working on Drupal.Commenting.VariableComment coding standard errors.

CommentFileSizeAuthor
#2 issue-2924779-2.patch12.04 KBzaporylie

Comments

zaporylie created an issue. See original summary.

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Status: Active » Needs review
StatusFileSize
new issue-2924779-2.patch12.04 KB

This patch extracts from #2909372-12: Enable 'Drupal.Commenting.VariableComment.MissingVar' coding standard all invalid @var annotations, ie. @param, @return, @string, Array, etc.

martin107’s picture

martin107 commented
Status: Needs review » Reviewed & tested by the community

This looks good I can justify every change.

The less @cars the better

  • xjm committed 5d2b7fb on 8.5.x 
    Issue #2924779 by zaporylie, martin107: Fix existing but somehow invalid...

  • xjm committed 082928a on 8.4.x 
    Issue #2924779 by zaporylie, martin107: Fix existing but somehow invalid...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

The less @cars the better

Agreed!

Thanks @martin107 and @zaporylie. This split should make it easier to review.

All these changes are obviously correct from the word diff. Committed to 8.5.x. I also backported it straight to 8.4.x since there's no rule added and so it's pure docs cleanup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.