The Rules project is using RouteEnhancerInterface which has been deprecated in core 8.5 since 24 October 2017 #2883680: Force all route filters and route enhancers to be non-lazy.
However, from 10th November this has caused Scheduler tests to fail at 8.5, due to #2870194: Ensure that process-isolated tests can use Symfony's PHPunit bridge to catch usages of deprecated code and we now get
\Drupal\Core\Routing\Enhancer\RouteEnhancerInterface is deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0. Instead, you should use \Drupal\Core\Routing\EnhancerInterface. See https://www.drupal.org/node/2894934
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 2924353-3.legacy_group_for_rule_tests.patch | 1.92 KB | jonathan1055 |
Comments
Comment #2
jonathan1055 commentedIt is difficult for Rules to fix the code immediately since the replacement classes have not been backported to 8.4 and 8.3 - see #2922757: Replace deprecated RouteEnhancerInterface, then remove @group legacy
As it will be some time before this is resolved, we can add the
@group legacytag to our rules_integration tests so that they pass at 8.5Comment #3
jonathan1055 commentedPatch adds
@group legacyto the three Rules test files. Both local testing and on Travis, the deprecation total count is still shown but the overall test result is a sucessful run.Comment #5
jonathan1055 commentedWe have tests passing again at 8.3, 8.4 and 8.5 :-)
Comment #6
jonathan1055 commentedI have raised #2924899: Backport \Routing\EnhancerInterface to core 8.4 which, if done, will allow Rules to remove the deprecated code, then Scheduler can remove the
@group legacytags in Rules tests.Comment #7
jonathan1055 commentedAlso the
@group legacytags could be removed if something like #56 in #2607260-56: [meta] Core deprecation message introduction, contrib testing etc. is implemented.