When theming the cookie notification, we added some padding to it, but the JS did not account in it's animation for the padding.
Attached patch changes the JS to account the outerheight instead of heigt for that.

CommentFileSizeAuthor
#3 eu_cookie_compliance-use-outerheight-for-animation-2923049-3.patch1.88 KBsvenryen
#2 2923049-eu_cookie-adjust-outerheight.patch766 bytesmallezie

Comments

mallezie created an issue. See original summary.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Status: Active » Needs review
StatusFileSize
new 2923049-eu_cookie-adjust-outerheight.patch766 bytes

And a patch

svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-use-outerheight-for-animation-2923049-3.patch1.88 KB

Actually, height() was used in several places. Here's an updated patch that takes all occurrences into account.

  • svenryen committed 9e16d98 on 8.x-1.x authored by mallezie 
    Issue #2923049 by mallezie, svenryen: use outerheight for sliding...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.