Problem/Motivation
When no revision log is entered, a list of fields that have changed is displayed in the revision overview. However, once a revision log message is entered, the list of changes goes away and only the log message is displayed.
Proposed resolution
It would be nice to display both.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2921962-2890116-combo.txt | 14.17 KB | jhedstrom |
| #3 | 2921962-03.patch | 3.43 KB | jhedstrom |
Comments
Comment #2
jhedstromComment #3
jhedstromAttached is a patch that shows both (and also a whitespace diff for ease of review). Finally, a patch combining #2890116: Display content moderation state change on diff overview form is attached since this touches the same code and that patch no longer applies cleanly with these changes.
Comment #4
jhedstromOops, this is the correct combination patch.
Comment #5
miro_dietikerI'm no more sure about that changed fields thing at all :-)
The revision log page takes forever to load. It's a super heavy operation, especially combined with entity reference revisions / paragraphs.
The field names are in many cases totally meaningless and i do consider replacing that output with some diff text teaser.
See added related task i just created.
Comment #6
jhedstromSo I guess whether it's a list of changed fields, or a diff as proposed in #2922094: Show diff instead of field names in summary, this issue is more about showing both the fields changed (or diff), and the revision log message. Current behavior without this patch is to just display the revision log message if that exists, and hide the other information which leads to confusion amongst end users.
Comment #7
berdirGenerating either a list of field names or an actual diff is way too slow at runtime, and we need to remove it. We could then afterwards look into generating it when an entity revision is saved, but actually not sure how that would work when combined.
Comment #8
miro_dietikerThe other patch was committed.
Since we said in the other issue about code complexity that we even will drop the autogenerated summary from runtime until we have a version that is written to storage, it seems there is no actionable item remaining here?