Problem/Motivation

Currently, if core's content moderation module is enabled, and a node is transitioned from one state to another, the revisions tab shows no change:

Proposed resolution

If the content moderation module is enabled, display relevant state change information on the overview form (eg, draft -> published, or similar).

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2890116-08.patch11.07 KBjhedstrom
#8 interdiff-2890116-07-80.txt1.4 KBjhedstrom
#7 2890116-07.patch10.12 KBjhedstrom
#7 interdiff-2890116-04-07.txt2.42 KBjhedstrom
#4 2890116-04.patch7.87 KBjhedstrom
#4 interdiff-2890116-02-04.txt5.73 KBjhedstrom
#2 2890116-02.patch2.71 KBjhedstrom
#2 Screen Shot 2017-06-27 at 3.27.54 PM.png69.2 KBjhedstrom
Screen Shot 2017-06-27 at 3.03.45 PM.png34.84 KBjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Issue summary: View changes
Status: Active » Needs review
FileSize
Screen Shot 2017-06-27 at 3.27.54 PM.png69.2 KB
2890116-02.patch2.71 KB

This is a first attempt. It now looks like this:

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented

I can write a test for this once #2887598: Fix test failing is resolved.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
FileSize
interdiff-2890116-02-04.txt5.73 KB
2890116-04.patch7.87 KB

Here's a start at some tests. Note these are currently failing due to a core bug: #2899719: Revision/version language on revision listing page is misleading with content moderation enabled.

Status: Needs review » Needs work

The last submitted patch, 4: 2890116-04.patch, failed testing. View results

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Related issues: +#2899719: Revision/version language on revision listing page is misleading with content moderation enabled
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs work » Needs review
FileSize
interdiff-2890116-04-07.txt2.42 KB
2890116-07.patch10.12 KB

Since #2899719: Revision/version language on revision listing page is misleading with content moderation enabled is most likely going to be only a label change effort, that need not block this. I've adjusted the tests to take into account when content moderation is enabled, and this should still be green. Still to do is to write some quick tests specific to the display of content moderation states on the revision overview form.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
FileSize
interdiff-2890116-07-80.txt1.4 KB
2890116-08.patch11.07 KB

This adds tests specific to content moderation.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Workflow Initiative

LGTM

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

How about starting the diff summary with the published state? Could be displayed as a badge or so, less looking like plain text... Maybe only if the state changed from previous visible revision?

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented

Displaying a badge would be tricky, as the workflow states can be completely changed (can't assume the basic editorial workflow that ships with content_moderation).

johnwebdev’s picture

johnwebdev CreditAttribution: johnwebdev commented
Issue tags: +Needs reroll

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Reviewed & tested by the community » Fixed

Great, committing the added info as-is.
I'm still hoping that core further iterates on the revision tab and we can catch up later.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.