I don't see any dependency on the action module in scheduler. Why do we have a dependency in the info file?

CommentFileSizeAuthor
#2 2921593-2.remove-dependency-on-action.patch364 bytesjonathan1055

Comments

chr.fritsch created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new 2921593-2.remove-dependency-on-action.patch364 bytes

Hi chr.fritsch,

You know, that is a very good question! On first doing some tests I don't think Scheduler does need the Action module. We make use of the 'actions' system to publish and unpublish content (see schedulerManager.php) but I think this is in core now. Maybe in earlier version of core 8.x this was not the case, or maybe at the initial conversion of Scheduler from 7.x it was done using the Actions module.

Here's a patch without the dependency. It all runs OK locally, and interactive testing also seems fine.

  • jonathan1055 committed 7e8bee5 on 8.x-1.x 
    Issue #2921593 by jonathan1055, chr.fritsch: Why is the action module...
jonathan1055’s picture

jonathan1055 commented
Title: Why is the action module needed for scheduler? » Remove unrequired dependency on Action module
Status: Needs review » Fixed

Thanks. Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.