Problem/Motivation
The key database_text is not part of search_api_db.backend.schema. Which makes sense, because it's just a text field in the form.
But currently it will be exported in the database configuration files, which creates schema errors.
Proposed resolution
Prevent exporting of the database_text key in the database config files.
Remaining tasks
Do it.
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 2921582-5.patch | 1.41 KB | drunken monkey |
Comments
Comment #2
chr.fritschHere is the patch
Comment #3
drunken monkeyThanks a lot for reporting this issue!
I wasn't aware of this behavior – and it seems pretty counter-intuitive to me. Why would you want input from an "item" field by default?
The reasoning in
\Drupal\Core\Render\Element\Item::getInfo()also seems to very accurately point out how nonsensical this default is:I.e.: Instead of letting those few forms that really need it set this manually, we're picking a counter-intuitive default value for everyone else …
But OK, enough ranting. The patch obviously fixes this for us, so great job!
Before I commit this, though: Do you know how we can trigger a config schema check within our tests? Seems like a nice idea to add a test not for this bug in particular (which would of course be trivial), but generally for whether re-saving our default server leads to a schema violation. The attached doesn't seem to be enough for that.
Comment #5
drunken monkeyOh, seems I was mistaken. Even better.
Combined patch attached.
Comment #7
drunken monkeyAwesome! Committed.
Thanks again for the report and the patch!