We have a client who would like to be able to provide a different popup message for mobile devices.

I'll upload a patch which provides this feature shortly.

CommentFileSizeAuthor
#7 eu_cookie_compliance-alternate-message-for-mobile-2921182-7.patch8.37 KBsvenryen
#4 interdiff-2921182-2-4.txt1.43 KBLNakamura
#4 2921182-4-Alternate-mobile-popup-message.patch6.15 KBLNakamura
#2 2921182-2-Alternate-mobile-popup-message.patch5.48 KBLNakamura
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LNakamura created an issue. See original summary.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented
FileSize
2921182-2-Alternate-mobile-popup-message.patch5.48 KB
shrop’s picture

shrop CreditAttribution: shrop at Mediacurrent commented

Consider adding configuration to adjust the max-width px setting in JS so it doesn't have to be hardcoded. I bet someone here can confirm if that makes sense and patch it up.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented
FileSize
2921182-4-Alternate-mobile-popup-message.patch6.15 KB
interdiff-2921182-2-4.txt1.43 KB

Fixed a bug (new message wasn't being saved on config save), and changed the max-width to 600px in the JS, which matches the media query in eu_cookie_compliance.css.

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented

Thanks, @shrop - another option would be to follow what's outlined here: https://www.lullabot.com/articles/importing-css-breakpoints-into-javascript

LNakamura’s picture

LNakamura CreditAttribution: LNakamura at Mediacurrent commented
Status: Active » Needs review
svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
FileSize
eu_cookie_compliance-alternate-message-for-mobile-2921182-7.patch8.37 KB

Here's an improved patch that allows the user to input the mobile breakpoint. 600 makes little sense, so I adjusted it to 768 px. It's debatable whether the css also should have 768 as the breakpoint.

I also tidied up the admin form, so that the option is exposed only when clicking a checkbox.

  • svenryen committed e34aaf9 on 8.x-1.x authored by LNakamura 
    Issue #2921182 by LNakamura, svenryen: Provide alternate popup message...
svenryen’s picture

svenryen CreditAttribution: svenryen at Ramsalt Lab commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.