Comments

MegaChriz created an issue. See original summary.

megachriz’s picture

Status: Active » Needs review
StatusFileSize
new1.64 KB

Status: Needs review » Needs work

The last submitted patch, 2: feeds-simplepie-missing-in-tests-2921027-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

Status: Needs work » Needs review
StatusFileSize
new2.09 KB

I don't know why the tests are failing. The failing test in question is passing locally. Let's try with debug code.

Status: Needs review » Needs work

The last submitted patch, 4: feeds-simplepie-missing-in-tests-2921027-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

megachriz’s picture

I opened #2921086: Download zip file from GitHub fails during testing in the DrupalCI: Test Runner issue queue.

megachriz’s picture

More debug code and changed url to "https://codeload.github.com/simplepie/simplepie/zip/$version" as I found out that GitHub issued a redirect. Also reduced tests being run by overriding run() method.

megachriz’s picture

Status: Needs work » Needs review
StatusFileSize
new2.22 KB

I changed the GitHub URL so no redirect is needed and now it is working?

Some issues in the downloadExtractSimplePie() though. Attached patch should fix that.

megachriz’s picture

That was only the interdiff. Here is the patch.

  • MegaChriz committed 0d998d0 on 7.x-2.x
    Issue #2921027 by MegaChriz: fixed failing tests due to SimplePie...
megachriz’s picture

Status: Needs review » Fixed

Great! Tests are passing again! Committed #9.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.