Apparently, the url http://simplepie.org/downloads/simplepie_1.3.mini.php no longer exists and this results into failing tests.
SimplePie 1.3 can now be found on github, with the following url:
https://github.com/simplepie/simplepie/archive/1.3.zip
Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | feeds-simplepie-missing-in-tests-2921027-9.patch | 2.02 KB | megachriz |
| #8 | interdiff-2921027-2-9.txt | 2.22 KB | megachriz |
| #7 | interdiff-2921027-4-7.txt | 13.56 KB | megachriz |
| #7 | feeds-simplepie-missing-in-tests-2921027-7.patch | 14.89 KB | megachriz |
| #4 | feeds-simplepie-missing-in-tests-2921027-4.patch | 2.09 KB | megachriz |
Comments
Comment #2
megachrizComment #4
megachrizI don't know why the tests are failing. The failing test in question is passing locally. Let's try with debug code.
Comment #6
megachrizI opened #2921086: Download zip file from GitHub fails during testing in the DrupalCI: Test Runner issue queue.
Comment #7
megachrizMore debug code and changed url to "https://codeload.github.com/simplepie/simplepie/zip/$version" as I found out that GitHub issued a redirect. Also reduced tests being run by overriding
run()method.Comment #8
megachrizI changed the GitHub URL so no redirect is needed and now it is working?
Some issues in the
downloadExtractSimplePie()though. Attached patch should fix that.Comment #9
megachrizThat was only the interdiff. Here is the patch.
Comment #11
megachrizGreat! Tests are passing again! Committed #9.