After upgrading from alpha8 to beta1 or beta2, I'm seeing an error message in /admin/config/workflow/rules for the "Discount shipping services" rule. This rule appears to have been added to commerce_discount.rules_defaults.inc in beta1. See screenshot attached.

It looks as though, at the very least, commerce_shipping is now a dependency, but I'm not using it and it's not listed in the .info file except as a test dependency.

Either it should be added as a dependency or (better, in my opinion, though more complicated), it rule shouldn't be installed unless/until needed.

CommentFileSizeAuthor
#4 2920331-4.default_shipping_discount.patch1.4 KBrszrama
Untitled-1.png58.48 KBrclemings

Comments

rclemings created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Related issues: +#2910160: Fix the "free shipping" offer type

Introduced this in #2910160: Fix the "free shipping" offer type, cross referincing so the authors know.

rszrama’s picture

rszrama commented

Oof, you're right. This should be wrapped in a module_exists() check. Will fix ASAP.

rszrama’s picture

rszrama commented
Status: Active » Needs review
StatusFileSize
new 2920331-4.default_shipping_discount.patch1.4 KB

Patch attached.

rclemings’s picture

rclemings commented
Status: Needs review » Reviewed & tested by the community

Works for me.

thx

  • joelpittet committed 10fbf11 on 7.x-1.x authored by rszrama 
    Issue #2920331 by rszrama, rclemings: Commerce shipping dependency?
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks, I've committed and pushed this to the latest -dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.