Call-time pass-by-reference has been deprecated [#292014]

After enabling module I throw the following error.

Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of conditional_fields_set_required_for_render(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /mnt/local/home/escapecm/escapecme.com/sites/all/modules/conditional_fields/conditional_fields.module on line 899

Comment	File	Size	Author
#2	remove_pass-by-ref_warning.patch	982 bytes	threexk
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

threexk CreditAttribution: threexk commented 6 August 2008 at 17:25

Priority:

Critical

» Normal

This issue was identified in http://drupal.org/node/269145 and I wrote a patch, but apparently my patch was incomplete. On that line you mention, the ampersand just needs to be removed. I'll post a new patch shortly.

I'm changing the priority on this bug to normal because the module still operates properly with the warning.

Comment #2

threexk CreditAttribution: threexk commented 6 August 2008 at 17:44

Status:

Active

» Needs review

File	Size
remove_pass-by-ref_warning.patch	982 bytes

Comment #3

peterpoe CreditAttribution: peterpoe commented 7 December 2008 at 19:30

Status:

Needs review

» Closed (duplicate)

Comment #4

threexk CreditAttribution: threexk commented 27 January 2009 at 20:22

Status:

Closed (duplicate)

» Active

peterpoe: This issue is indeed a duplicate of http://drupal.org/node/269145, but by my mistake the patch for that issue only fixed one out of two warnings. That's why this issue was created. This line still needs its ampersand removed:
conditional_fields_set_required_for_render(&$item);

Can you make this change directly, or should I make a new patch?

Comment #5

peterpoe CreditAttribution: peterpoe commented 31 January 2009 at 17:07

Required fields in d5 are still buggy (see also #292044: Required fields within conditional groups not indicated as required). In d6 after many changes (in d6 the function conditional_fields_set_required_for_render does not even exist!) they work correctly, but the fixes have not been yet backported to d5. Will backport the fixes from d6 as soon as d6 is ready for release (it should not take long), but if you want to help with this you are welcome.