Exclude temporary (and deleted) files from duplicate-file prevention

Something like altering the query in filehash_validate_dedupe() that way :

     $query = \Drupal::database()->select('filehash', 'fh');
     $query->addField('fh', 'fid');
     // Do not check temp files (removed every 6 hours @see file_cron()).
     $query->join('file_managed', 'fm', 'fh.fid=fm.fid');
     $query->condition('fm.status', 1, '=');
     // Do not check itself :).
     $query->condition('fh.fid', (int) $file->id(), '!=');
     // Check if hash match.
     $query->condition('fh.' . $algo, $file->filehash[$algo]);
     $query->range(0, 1);

Sounds sensible to me. Adding needs test tag (it also needs a patch of course :)

The one kinda big problem with this is that it allows duplicate files to be uploaded at the same time (either by the same user, or different users), if they're both temporary files.

Ideally we could fix this upstream in Drupal core - temporary and deleted could be different file statuses?

We encounter this issue weekly, sometimes daily, with our users. Sometime they upload a file and then don't finish the process of saving the object the file is attached to (usually a media entity but in some cases filefield on node). Then they try again and get the duplicate file error.

We recently added the https://www.drupal.org/project/media_entity_file_replace module to allow replacing/updating a file while optionally maintaining the original filename, but when there is a validation error (some other required field not filled in or whatever) this module doesn't "carry along" the temporarily uploaded new file and thus the user is stuck with another duplicate file error.

The one kinda big problem with this is that it allows duplicate files to be uploaded at the same time (either by the same user, or different users), if they're both temporary files.

To this point, I think it would be a pretty rare occurrence for this to happen and if it was by the same user on the same edit form, at least only one file would be marked as permanent and the duplicate temp file would be removed eventually anyway.

This feels more like a feature request / enhancement than bug report - it's working as designed but UX is quite poor :)

Using https://www.drupal.org/project/filehash/issues/2920042#comment-12919090 to create a patch to exclude temporary files from duplicate-file-prevention

• drupal 9.2.7
• version 8.x-1.5

Patch doesn't apply, and needs tests

Here's a patch that should apply cleanly. No tests added so keeping status as Needs work.

Still needs tests (and there is a minor code style issue to fix up)

Code style issue fixed, I believe.

I have work underway on this in the 2.x branch (still needs test coverage)

Functional test for this feature

Patch #17 worked in my case. Thanks