Split off from #2873881: [meta] Add Change Record to @deprecated for common.inc because these types of issues need to scoped by change record not file.

To determine how to complete this issue see #2873705: Add change records to all @deprecated code

Related change record: https://www.drupal.org/node/2560027

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Issue summary: View changes
tedbow’s picture

shashikant_chauhan’s picture

Status: Active » Needs review
FileSize
1.24 KB

Adding patch.

tedbow’s picture

Status: Needs review » Reviewed & tested by the community

@shashikant_chauhan thanks for the patch!

+++ b/core/includes/common.inc
@@ -209,9 +209,6 @@ function valid_email_address($mail) {
- * @see \Drupal\Component\Utility\UrlHelper::stripDangerousProtocols()
- * @see \Drupal\Component\Utility\UrlHelper::filterBadProtocol()
- *

I think it makes sense to move these @see tags down with the new @see tag added for the CR!

Looks good. I checked the related CR and the connected issue. check_url() is the only @deprecated code in the issue.

🎉🎉R.T.B.C🎉🎉

  • xjm committed 754883a on 8.5.x
    Issue #2920008 by shashikant_chauhan: Add Change record to @deprecated...

  • xjm committed 1a3caf9 on 8.4.x
    Issue #2920008 by shashikant_chauhan: Add Change record to @deprecated...
xjm’s picture

Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Looks good to me as well. Thanks @shashikant_chauhan!

Committed and pushed to 8.5.x, and backported to 8.4.x as a docs improvement.

xjm credited kwhite.

xjm’s picture

Oops, belatedly adding credit for kwhite who was the one who researched this at the sprint.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.