Remove redundant granularity when displaying whole months and/or years

Hi,

For now there are options All month and All year in config form.

Please, test the patch.

Also reduced unnecessary string translations.

Re-arranged month and year fields.
Added extra description.

@matsbla Have you run drush updb command to perform DB update?

Error while applying the patch:

Checking patch config/install/daterange_compact.date_range_format.medium.yml...
Checking patch config/schema/daterange_compact.schema.yml...
Checking patch daterange_compact.install...
error: daterange_compact.install: No such file or directory
Checking patch src/DateRangeFormatter.php...
Checking patch src/Form/DateRangeFormatForm.php...

Followed below steps:

1. git clone --branch 8.x-1.x https://git.drupal.org/project/daterange_compact.git
2. cd daterange_compact
3. wget https://www.drupal.org/files/issues/2018-09-15/daterange_compact-provide...
4. git apply -v daterange_compact-provide_opion_to_remove_redundant_date-2919426-6-D8.patch

Hi,

@ajay_reddy Please try alternative command to apply patch:
patch -p1 < daterange_compact-provide_opion_to_remove_redundant_date-2919426-6-D8.patch

Because patch contains file (daterange_compact.install) that is not presented in git index.

Regards!

Add checkbox to Enable/Disable short month(s)/year(s) patterns.

Fix error: daterange_compact.install: No such file or directory during patch applying.

Mats, I added small improvements and #15 is the best for now.

Thank you @sergei_semipiadniy and @matsbla for your contributions and helping move this forward.

I'm trying to clarify the use case and see what is and isn't available already.

I tried to recreate the first example described in the issue summary:

• create a date range field with start date "2021-01-01" and end date "2021-12-31".
• create a format with a basic pattern of Y and no special same day/month/year handling.

The output is "2021", which is what I expected.

Then I tried to recreate the second example:

• create a date range field with start date "2021-12-01" and end date "2021-12-31".
• create a format with:
  • a basic pattern of F Y
  • a same year start pattern of F
  • a same year end pattern of F Y
  • no same month start pattern
  • a same month end pattern of F Y

The output is "December 2021", which is also what I expected.

That mimics the test coverage that exists for those two use cases.

Have I understood the issue summary correctly? Or is there something else I've missed that the patch provides? In which case, let's clarify that so we can add a test for it.

Updated patch to make values persistent

01.01.2000-31.2.2000 = Jan - Feb 2000
01.10.2000-31.01.2001 = Oct 2000 - Jan 2001

You can already do that much without the patch, using the patterns in #21. So I've misunderstood something.

Let's clarify the requirements a bit more and get some concrete examples. Then we can turn those into tests.

A quick look through the patch suggests you want to use a different pattern when the range spans a whole month (or a whole year). In other words, one format that can do the following:

• for a range from 1 Jan 2021 to 15 Jan 2021, display "1 - 15 January 2021"
• for a range from 1 Jan 2021 to 31 Jan 2021, display only "January 2021"

This would consider "1 - 31" redundant (in the context of January 2021) and remove it, but leave in "1 - 15".

Have I understood this correctly?

Got it! I've updated the issue summary with this clarification.

Thanks for adding the tests too, that's a big help.