I can see possible code bug inside TermStorageSchema class:
protected function getEntitySchema(ContentEntityTypeInterface $entity_type, $reset = FALSE) {
$schema = parent::getEntitySchema($entity_type, $reset = FALSE);
The $reset parameter is always set to FALSE - I can't see any reason for doing this - is it by purpose or just a copy/paste bug?
I can't find similar approach anywhere else - e.g. UserStorageSchema or NodeStorageSchema are passing variable correctly:
protected function getEntitySchema(ContentEntityTypeInterface $entity_type, $reset = FALSE) {
$schema = parent::getEntitySchema($entity_type, $reset);
Comments
Comment #2
kybermanHere is the patch.
Comment #3
borisson_This is a bug, but as this passed tests before, it looks like we don't have enough test-coverage.
Comment #6
andypostNot clear how to test this protected method but surely it is typo
Comment #7
andypostFound the same bug in webforms #2999896: Fix reset parameter inside getEntitySchema parent call in WebformSubmissionStorageSchema
Comment #8
andypostThis comes from initial commit #2326949: Move entity-type-specific schema information from the storage class to a schema handler
Comment #9
amateescu commentedI think this would be quite hard to test, and not really worth it for an obvious copy-paste mistake.
Comment #10
andypostreroll
Comment #11
alexpottCommitted and pushed 6b623b4e08 to 8.7.x and c03db884ca to 8.6.x. Thanks!