There are two submodules whose names differ only by a a plural:

Password Character Type Policy
Password Character Types Policy

And their descriptions are:

Identifies the number of specific character type in a password.
Sets up a character types constraint for passwords.

I can't tell the difference from those either.

I looked at the code in the plugins, and I am still not clear on what the difference is.

CommentFileSizeAuthor
#7 Screen Shot 2018-07-27 at 3.44.14 PM.png38.03 KBdaggerhart
#4 password_policy-8.x-3.x-better_distinguish_character_type_constraints-2918957-4.patch1.18 KBaohrvetpv

Comments

joachim created an issue. See original summary.

aohrvetpv’s picture

aohrvetpv commented
Priority: Major » Normal

I will explain the difference.

"Character Types" is the same as "Character Types" in 7.x-1.x and 7.x-2.x. You specify a number of different character types the password must have. There are four character types: lower, upper, digit, special. So, if you specify 3, the password must contain any 3 out of the 4 types.

With "Character Type" you specify how many characters of a given character type the password must have. So, you could specify that the password must have 2 special characters and 1 upper character.

This issue doesn't seem "Major" per the Priority definitions, but I think the names are confusingly similar and should be changed for clarity. Perhaps "Characters of Type" instead of "Character Type"?

aohrvetpv’s picture

aohrvetpv commented

Some previous discussion of the confusingly similar names starting with my comment here: #2667486-15: Implement the "character types" password constraint..

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-8.x-3.x-better_distinguish_character_type_constraints-2918957-4.patch1.18 KB

This patch attempts to clarify the constraint names and descriptions. Better?

Notes:
- The descriptions I wrote are sentence fragments. They could be begun with "Specifies" if proper sentences are desired.
- The patch does not change the names in code or filenames.

aohrvetpv’s picture

aohrvetpv commented

Another renaming possibility: Character Type -> Character Type Length

So you'd have:
Character Type Length
Character Types

aohrvetpv’s picture

aohrvetpv commented
Title: two submodules sound indentical: Password Character Types Policy, Password Character Type Policy » two submodules sound identical: Password Character Types Policy, Password Character Type Policy
daggerhart’s picture

daggerhart commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2018-07-27 at 3.44.14 PM.png38.03 KB

Good idea, I think this is a valid complaint that can be easily fixed.

Patch applied cleanly on simplytest, and the UI reflects the patch changes.

modules list page with patch changes shown

RTBCed

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Reviewed & tested by the community » Patch (to be ported)

Ive reviewed the code, tested, and i'm merging.

  • nerdstein committed d854d59 on 8.x-3.x authored by AohRveTPV 
    Issue #2918957 by AohRveTPV, daggerhart: two submodules sound identical...
nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented
Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.