The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.The basic authentification doesn't work. I've got a 401 error from the provider.
After having a look, i can see that an issue was created line 244.
The correct line should be :
curl_setopt($download, CURLOPT_USERPWD, $options['username'] . ':' . $options['password']);
and not
curl_setopt($download, CURLOPT_USERPWD, '{' . $options['username'] . '}:{' . $options['password'] . '}');
I thing that the mistake was made when integrating properties into $options...
Cheers,
Cyril
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | feeds-http-request-authorize-2918931-4.patch | 2.49 KB | megachriz |
| #4 | feeds-http-request-authorize-2918931-4-tests-only.patch | 1.77 KB | megachriz |
| #3 | feeds-http-request-authorize-2918931-3.patch | 738 bytes | megachriz |
Comments
Comment #2
megachrizThe conversion happened in #2877125: Refactor http_request_get().
Previously the line was this:
curl_setopt($download, CURLOPT_USERPWD, "{$username}:{$password}");I see that the curly braces shouldn't been copied over indeed. Its use is explained on http://php.net/manual/en/language.types.string.php#language.types.string....
I missed that as I only use curly braces in strings when I need to print a property of an object:
{$object->property}.Comment #3
megachrizI provided your suggested change as a patch, so automated tests run against the change.
Comment #4
megachrizNow with a test. The test only patch should fail.
Comment #7
megachrizCommitted #4. Thanks for reporting!
Comment #9
chankongching commentedu gotta run the git clone once before execution of any command to add the remote resources into your know_hosts