Hey,

When I add the block menu via context ui there is no the option of "Multilingual options".
I will be glad if somebody can fix it...

thanks

CommentFileSizeAuthor
#13 not_work_in_context-2917338-13.patch6.6 KBipumpkin
#11 not_work_in_context-2917338-11.patch8.29 KBipumpkin
#8 not_work_in_context-2917338-8.patch5.64 KBipumpkin
#6 not_work_in_context-2917338-6.patch8.15 KBipumpkin
#3 screen.png56.25 KBberin

Comments

berin created an issue. See original summary.

matsbla’s picture

matsbla commented
Status: Active » Postponed (maintainer needs more info)

Can you give exact steps to reproduce?

berin’s picture

berin commented
StatusFileSize
new screen.png56.25 KB

I added the block of the menu to a region with context.
I dont have there the "Multilingual options"
Structure -> context -> add context -> add reaction -> block -> place block -> main navigation and then see at the image attached the block I get without this option.

berin’s picture

berin commented

??

matsbla’s picture

matsbla commented
Status: Postponed (maintainer needs more info) » Active

I can confirm it is not working when using contexts.

I will not prioritize make a fix for it right now, but will consider any patch you can provide to fix the issue!

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Active » Needs review
StatusFileSize
new not_work_in_context-2917338-6.patch8.15 KB

Maybe you can use this patch for panels or context.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Needs work

@ipumpkin, I haven't yet tested, but it seems that your patch should be rewrited to reflect cnahges from #2925485: Some times not translated item appear in menu.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
StatusFileSize
new not_work_in_context-2917338-8.patch5.64 KB

@vlad.dancer fixed.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Needs work » Needs review
matsbla’s picture

matsbla commented

@ipumpkin
Thanks for this!
I tested it now and It seems like this is not working when using the Menu block module,

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
StatusFileSize
new not_work_in_context-2917338-11.patch8.29 KB

@matsbla Add suport for menu_block.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs review » Needs work 
+++ b/src/Plugin/Block/SystemMenuBlockMultilingual.php
@@ -0,0 +1,69 @@
+  public function blockForm($form, FormStateInterface $form_state) {

I believe that all this methods, like blockForm, blockSubmit, defaultConfiguration could be moved to the trait, let's say MenuMultilingualBlockTrait and reused either for MenuBlockMultilingual or SystemMenuBlockMultilingual to follow DRY principle

@ipumpkin, what do yuo think?

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
StatusFileSize
new not_work_in_context-2917338-13.patch6.6 KB

@vlad.dancer You are right,it's a good advice.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Needs work » Needs review
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented

Looks good to me. @matsbla, could you do manual test?

matsbla’s picture

matsbla commented
Status: Needs review » Reviewed & tested by the community

Tested and works good!

  • vlad.dancer committed 90a32b1 on 8.x-1.x authored by ipumpkin 
    Issue #2917338 by ipumpkin, berin, matsbla, vlad.dancer: not working...
vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Status: Reviewed & tested by the community » Fixed

@ipumpkin, thanks. Fixed.

vlad.dancer’s picture

vlad.dancer
Primary language Ukrainian
Location Kyiv
commented
Assigned: berin » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.