Problem/Motivation

The taxonomy module hard-codes some node functionality that is hard-coupled in the module. Taxonomy uses default field storage to store canonical relationships between terms and fieldable entities. However in relation with the Node entity it uses a dedicated denormalized table {taxonomy_index} to avoid slow queries due to joining across multiple node and field tables with various conditions and order by criteria. It's possible for a 3rd party module to implement its own custom storage engine that uses alternative methods of denormalizing this data, but right now this is not managed by an API.

Proposed resolution

  • Remove the node code from taxonomy.
  • Provide a common API to make this process pluggable.

Remaining tasks

  • Reroll per #16
  • Add tests
  • Move the taxonomy.settings:maintain_index_table in the Node module while still keeping BC. Add upgrade path and upgrade path tests.

User interface changes

None.

API changes

  • New plugin type: \Drupal\taxonomy\TermReferenceInterface
  • Add a plugin implementation for Node
  • Plugin manager

Data model changes

None.

CommentFileSizeAuthor
#20 interdiff_19-20.txt1.42 KBnikhil_110
#20 2917209-20.patch22.29 KBnikhil_110
#19 2917209-19.patch22.37 KBprem suthar
#18 interdiff_17-18.txt3.37 KBpooja saraah
#18 2917209-18.patch22.41 KBpooja saraah
#17 2917209-17.patch22.46 KBsuresh prabhu parkala
#3 2917209-3.patch22.4 KBclaudiu.cristea
#3 2917209-3.interdiff.txt431 bytesclaudiu.cristea
#2 2917209-2.patch22.52 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new 2917209-2.patch22.52 KB

Give it a first try.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
StatusFileSize
new 2917209-3.interdiff.txt431 bytes
new 2917209-3.patch22.4 KB

Ops, the surgeon has left his knife inside.

The last submitted patch, 2: 2917209-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
Component: telephone.module » taxonomy.module

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Updated issue summary with a remaining task
This still needs an upgrade path and tests

Thanks!

suresh prabhu parkala’s picture

suresh prabhu parkala commented
StatusFileSize
new 2917209-17.patch22.46 KB

Re-roll to the latest 10.1.x. Please review.

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 2917209-18.patch22.41 KB
new interdiff_17-18.txt3.37 KB

Fixed failed commands on #17
Attached patch against Drupal 10.1.x
Attached interdiff

prem suthar’s picture

prem suthar commented
StatusFileSize
new 2917209-19.patch22.37 KB

Try To Fix The Failed Patch #18.

nikhil_110’s picture

nikhil_110 commented
StatusFileSize
new 2917209-20.patch22.29 KB
new interdiff_19-20.txt1.42 KB

Try To Fix the Failed Patch #19

nikhil_110’s picture

nikhil_110 commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Quick glance I don’t see if an update path was added

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.