Per the suggestion in #2692407: Test_dependencies are downloaded before applying patches, rather than after, add a composer.json file that lists the dependencies.

CommentFileSizeAuthor
#11 fieldable_panels_panes-n2916627-11.interdiff.txt745 bytesdamienmckenna
#11 fieldable_panels_panes-n2916627-11.patch1.02 KBdamienmckenna
#9 fieldable_panels_panes-n2916627-9.interdiff.txt855 bytesdamienmckenna
#9 fieldable_panels_panes-n2916627-9.patch1.04 KBdamienmckenna
#3 2916627-3.patch1.36 KBmanuel garcia
#3 interdiff.txt793 bytesmanuel garcia
#2 2916627-2.patch1.38 KBmanuel garcia

Comments

DamienMcKenna created an issue. See original summary.

manuel garcia’s picture

manuel garcia commented
Status: Active » Needs review
StatusFileSize
new 2916627-2.patch1.38 KB

Here is a start on this. Not terribly familiar with this process, specially when it comes to the dependencies for the test bot, but I think you declare them as part of require-dev. Not sure either about the versioning so please have a look =)

manuel garcia’s picture

manuel garcia commented
StatusFileSize
new interdiff.txt793 bytes
new 2916627-3.patch1.36 KB

Apologies for the indentations, my laptop died and I'm still setting up my old tower pc...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2825207: Plan for Fieldable Panels Panes 7.x-1.12 release

Committed, though I removed the maintainers and just left the "See all contributors" link. Thanks.

  • DamienMcKenna committed 082f659 on 7.x-1.x 
    Revert "Issue #2916627 by Manuel Garcia: Add a composer.json file to...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Fixed » Needs work
Parent issue: #2825207: Plan for Fieldable Panels Panes 7.x-1.12 release »

This broke the tests so I had to revert it.

manuel garcia’s picture

manuel garcia commented

Hummm any clue what specifically in this patch might have been the cause for that @DamienMcKenna?

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_panes-n2916627-9.patch1.04 KB
new fieldable_panels_panes-n2916627-9.interdiff.txt855 bytes

Lets try this again.

Status: Needs review » Needs work

The last submitted patch, 9: fieldable_panels_panes-n2916627-9.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new fieldable_panels_panes-n2916627-11.patch1.02 KB
new fieldable_panels_panes-n2916627-11.interdiff.txt745 bytes

Composer with Drupal 7 is a little different, lets see how this works.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2825207: Plan for Fieldable Panels Panes 7.x-1.12 release

Ok, that seems good enough for now.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.