Closed (fixed)
Project:
Webform
Version:
7.x-4.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Oct 2017 at 15:13 UTC
Updated:
7 Nov 2017 at 20:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
liam morlandComment #5
danchadwick commentedThis creates a regression because of the requirement for signatures to match in object inheritance hierarchies. There might be other issues, but the one I'm getting is:
Warning: Declaration of webform_exporter_excel_xlsx::add_row(&$file_handle, $data, $row_count) should be compatible with webform_exporter::add_row(&$file_handle, array $data, $row_count) in include_once() (line 6 of /var/www/drupal7/sites/all/modules/contrib/webform/includes/exporters/webform_exporter_excel_xlsx.inc).Comment #6
danchadwick commentedCommitted to 7.x-4.x
Comment #7
danchadwick commented@Liam Morland: Each maintainer needs to arrive at a maintenance philosophy that he/she is comfortable with. I tended to *not* make code changes for "clean up" purposes without significant community review. There isn't much upside and there is some downside, as this issue demonstrates. The choice is yours to make, of course. I'm just back-seat driving. :) Many thanks for all your work on webform.
Comment #9
liam morlandThanks, Dan.