Problem/Motivation

In Firefox redirect URL field is disabled and I'm unable to copy/paste it in Square OAuth settings app to gain application secret key

Proposed resolution

Add a click to copy. Or make it normal text that can be copied.

CommentFileSizeAuthor
#7 commerce_square-2915521-redirect-7.patch787 bytesczigor

Comments

krcha created an issue. See original summary.

krcha’s picture

krcha commented
Title: Update for Commerce 2.0-RC1 » Redirect url field is disabled
philsward’s picture

philsward commented

I ran into the same issue. I had to 'inspect' the form field to get the full address. Also on FF, v56

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

This is my bad. In Chrome it worked fine to highlight text.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
philsward’s picture

philsward commented

It looks like there's a "readonly" option. Are there any problems with changing diabled="" to readonly=""?

czigor’s picture

czigor commented
Status: Active » Needs review
StatusFileSize
new commerce_square-2915521-redirect-7.patch787 bytes

readonly has other problems (https://stackoverflow.com/questions/8876928/allow-copy-paste-in-a-disabl...). What about using an item form element instead?

Status: Needs review » Needs work

The last submitted patch, 7: commerce_square-2915521-redirect-7.patch, failed testing. View results

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Makes sense. Skip the fancy, just make it text.

spokje’s picture

spokje
Primary language Dutch
commented

Patch #7 is for version 8.x but tested against 7.x-1.x

czigor’s picture

czigor commented
Version: 7.x-1.0-beta6 » 8.x-1.x-dev

Ah, right, did not see the issue version. Let's commit to 8.x first and then backport.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Somehow Testbot decided to do the tests on #7 with PHP 5.6 & MySQL 5.5, D8.4 and PHP 7 & MySQL 5.5, D8.3 using the 7.x branch again, and obviously failing them.

Re-added tests against D8.5, they passed so back to Needs Review

  • czigor committed 2fcac5c on 8.x-1.x 
    Issue #2915521 by czigor, mglaman, krcha, philsward, Spokje: Redirect...
czigor’s picture

czigor commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Active

We need a backport.

  • czigor committed ba3be9d on 7.x-1.x 
    Issue #2915521 by czigor, mglaman, krcha, philsward, Spokje: Redirect...
czigor’s picture

czigor commented
Status: Active » Fixed

Committed, thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.