Field label not configurable from the UI and it's set from the module as street instead of Phone number or any related label title.

Label issue

CommentFileSizeAuthor
#10 international_phone-fix_custom_field_label-2915431-10-D8.patch1.11 KBrandell
#6 Before_Phone_Field.png60.33 KBriddhi.addweb
#6 After_Phone_field.png61.06 KBriddhi.addweb
#4 international_phone.jpg6.01 KBmqanneh
#3 international_phone.jpg32.11 KBmqanneh
#2 international_phone-fix_field_label-2915431-2.patch1.24 KBmqanneh

Comments

mqanneh created an issue. See original summary.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Assigned: mqanneh » Unassigned
Status: Active » Needs review
StatusFileSize
new international_phone-fix_field_label-2915431-2.patch1.24 KB

Changed field label from street into Phone number

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
StatusFileSize
new international_phone.jpg32.11 KB
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Issue summary: View changes
StatusFileSize
new international_phone.jpg6.01 KB
mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Category: Task » Feature request
Priority: Normal » Minor
riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After_Phone_field.png61.06 KB
new Before_Phone_Field.png60.33 KB

@mqanneh, Thanks for the correction, It works well for me As I checked it using Simplytest.me also attached screenshot for same.

hugronaphor’s picture

hugronaphor commented
Status: Reviewed & tested by the community » Needs work

There is no need at all to add #title nor #description property!
Just remove those and you're going to get the configured values from the field instance.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Needs work » Needs review

@hugronaphor kindly check the patch again. The patch didn't add #title or #description properties it just changed the #title value as below:

-      '#title' => $this->t('Street'),
+      '#title' => $this->t('Phone number'),
hugronaphor’s picture

hugronaphor commented

Yes, I do understand this.

But what if I want to have the label as "Telephone"? It should have the title I've configured on my field in UI.
It should be something like:

$element['value'] = $element + [
        '#type' => 'textfield',
        '#default_value' => isset($items[$delta]->value) ? $items[$delta]->value : NULL,
        '#attributes' => ['class' => ['international_phone-number']],
        '#attached' => [
          'library' => ['international_phone/international_phone'],
        ],
  ];

#title is already populated in $element

randell’s picture

randell commented
StatusFileSize
new international_phone-fix_custom_field_label-2915431-10-D8.patch1.11 KB

I created a patch based on Comment #9, which I've also tested on Drupal 8.5.5. It works the way regular field labels should work, which should be updatable.

hitchshock’s picture

hitchshock
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

It's working for me.

randell’s picture

randell commented

What's the next step in getting this patch released ?

  • randell authored 0316734 on 8.x-1.x 
    Issue #2915431 by mqanneh, randell, riddhi.addweb: Fix field label
mayurjadhav’s picture

mayurjadhav commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.