Closed (fixed)
Project:
Commerce Currency Switcher
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Oct 2017 at 14:05 UTC
Updated:
31 Oct 2017 at 15:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
luksakComment #3
ytsurkWe need our own cache context here.
Comment #4
ytsurkComment #5
luksakHere is this patch combined with #2895850: Implement automatic currency conversion based on set exchange rate instead of fixed price fields in comment #4 in case anyone needs it.
Comment #6
luksakSomething went wrong with the last patch. This one should work.
Comment #7
luksakThe patch in #4 works perfectly. RTBC!
Comment #8
mglamanWhy not just !empty($build[''])?
Tab not space.
Commented code.
Comment #9
ytsurk.
Comment #10
ytsurkStruggling with my texteditor .. sorry ..
Comment #11
ytsurkso here we go ..
Comment #12
ytsurkand finally ..
Comment #13
ytsurkno more comments
Comment #14
ytsurkBut here's the updated patch. Thank you for your suggestions.
As I don't like double negations, I left the array_key_exists.
Comment #15
mglaman+1
Side note for another issue: Using the session returned from the request is not as stable as using the normal session service. We experienced a lot of bugs when using this approach.
Comment #16
ytsurkJoin the discussion about the storage here #2914898: Store user's currency in a cookie instead of a session
Comment #17
luksakAbout to post a patch in that issue. Let's get this one committed since the other issue depends in this one.
Comment #18
sumanthkumarc commentedLast patch doesn't apply cleanly on latest head, so tweaking and committing.
Comment #20
sumanthkumarc commentedCommitted and Thanks @matt, @lukas and @ytsurk.