When a new user is added, the default value for the users "Your current logout threshold" is wrong.
Due to the user-id being NULL, the system reads every users logout threshold and uses them space-separated as the default value.

The provided patch checks for this edge case and fixes the bug.

CommentFileSizeAuthor
fix-new-user-default-threshold.patch736 bytesPatrick Bauer

Comments

Patrick Bauer created an issue. See original summary.

deaom’s picture

deaom commented
Status: Needs review » Reviewed & tested by the community

The patch applies. If you want to reproduce the bug without the patch, just add some users and give them different treshold values, then add a new user and you will se that all the previous users treshold values are listed in the textfield, divided by a blank space. After applying the patch, the treshold value is empty, so you can leave it empty or add a value.

Just be careful of the coding standards, one space is expected after the if keyword.

andypost’s picture

andypost
he/him
Primary language Russian
commented

+1 to rtbc

  • AjitS committed 436eb8c on 8.x-1.x authored by Patrick Bauer 
    Issue #2914041 by Patrick Bauer, DeaOm, andypost: New user threshold...
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented

Thank you for the patch, and reviews! Committed and pushed to 8.x-1.x

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Reviewed & tested by the community » Fixed

  • AjitS committed db3d606 on 8.x-1.x 
    Issue #2914041: Coding standard fix.
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Assigned: Patrick Bauer » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.