Port drush commands to drush 9.x

Not sure if this needs a new issue or not, but probably relevant here. When using the "key-save" command, which seems to work great at first, the key that is saved isn't given a UUID. This of course is a problem when exporting the configuration and importing it on another site.

Example:

drush key-save tmp --key-provider=file --label=Tmp --key-type=encryption --key-type-settings='{"key_size":256}' --key-provider-settings='{"file_location":"../keys/tmp.key","base64_encoded":true}' -y

Resulting key:

Thanks for the info about the null UUID. I've addressed it in #2935263: key-save Drush command does not generate UUID.

@kmoll - Are you actively working on this? If not, will you unassign yourself? Thanks.

Terrific, thanks!

Thanks, @kmoll. The key:save command looks good. Are you going to work on the other commands?

Those are the only issues I noticed. Thanks!

2912756-port-drush-15.patch unexpectedly undoes a few recent commits. Once I reverted those, the updated commands looked generally good. Here are some comments:

• The alias for key:value-get is key-test. It should be key-value.
• The alias is displayed for key:value-get, but not for any other commands. I can't seen any difference in the @aliases declarations and the aliases all seem to work.
• Perhaps it's my setup, but I'm randomly getting a thrown exception,
  Symfony\Component\Console\Exception\CommandNotFoundException, with the error There are no commands defined in the "key" namespace. Randomly, like issuing the same command repeatedly sometimes results in the exception and sometimes doesn't.

Ah, that makes sense about the aliases. The unpredictable errors did seem to be specific to my installation.

Here's a new patch with a few extra tweaks:

• Defined drush.services.yml as the Drush services file in composer.json
• Replaced deprecated _convert_csv_to_array calls with StringUtils::csvToArray
• Removed overwrite option from key:save and replaced it with a confirmation; removed confirmation when creating a new key with key:save
• Slightly modified the confirmation text to match other commands' confirmations

@kmoll - Can you take a look at the latest tweaks that I made and, if they look OK, mark this issue RTBC? Thanks.

I don't think this is RTBM yet. We need to change the current drush commands (to support Drush 8 and below) to use the service per http://gbyte.co/blog/creating-drush-9-commands-and-porting-legacy-commands. I think this means creating a new service, and calling that service from both the .drush.inc and KeyCommands. I'll work on that change.

@douggreen - The commands for both versions of Drush already call the same services provided by Key (e.g., key.repository, plugin.manager.key.key_type). Can you clarify what you mean?

@rlhawk I thought that we wanted to do something like the attached so that the code only needed to be maintained in one place, and so that we could add Drupal console support too. This doesn't quite work yet. The confirm() code needs to be sorted out. And for Drupal console we'll need to handle dt.

(BTW, I can't test with Drush 9 right now, something in master has a composer conflict, and isn't installing)

OK, I'll take a look.

I'd love to get the Drush 9 support committed. What do you think about doing the refactoring work in a separate issue?

I haven't found a single other project trying to maintain drush 8 and drush 9 commands with a compatibility layer. I think that the plan is to stop supporting the drush 8 commands, and eventually to remove them.

Let's go with #21. This is the way of the future.

The new command file is auto-generated. I have some critique of it. If we're going to fix anything, it shouldn't be here, but in the auto-generation.

IIRC, this was missing the new key-format from Drush 8, that now needs to be forward ported to Drush 9.