Needs to remove deprecated method assertEqual from core tests.
Attention:
Parameter $actual and $expected are swapped

  /**
   * @see \Drupal\simpletest\TestBase::assertEqual()
   *
   * @deprecated Scheduled for removal in Drupal 9.0.0. Use self::assertEquals()
   *   instead.
   */
  protected function assertEqual($actual, $expected, $message = '') {
    $this->assertEquals($expected, $actual, $message);
  }

Comments

karthikkumarbodu created an issue. See original summary.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented

Should we split this up into separate issues to avoid creating a large patch file?

karthikkumarbodu’s picture

karthikkumarbodu commented

Sounds like a good idea i will crate child issues for this issue.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Version: 8.4.x-dev » 8.5.x-dev

Also I guess this should be build against the latest 8 dev version.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue tags: +phpunit initiative

I like the idea, but I'm not sure we are ready for this yet. Since we are still converting WebTestBase test to PHPUnit, deprecated calls to assetEqual will be added during those conversions. And we don't want to update the calls during the conversions because that would make them really hard to review.

So I'd say that this needs to be postponed on #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase), same for the child issues.

ivan berezhnov’s picture

ivan berezhnov commented
Issue tags: +CSKyiv18

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

mmbk’s picture

mmbk
Primary language German
Location Meißen
commented
Issue summary: View changes

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

init90’s picture

init90
Location Ukraine
commented
Status: Active » Closed (duplicate)
Related issues: +#3131281: Replace assertEqual() with assertEquals()