hi,

UUID is null on config-export of facets.facet_source.*

uuid: null
langcode: en
status: true
dependencies: {  }
id: search_api__views_page__search_custom__page_1
name: 'search_api:views_page__search_custom__page_1'
filter_key: null
url_processor: query_string
breadcrumb: {  }
CommentFileSizeAuthor
#6 uuid_null_on-2911763-6.patch2.57 KBcato
#3 uuid_null_on-2911763-3.patch2.95 KBcato
#2 uuid_null_on-2911763-2.patch1.08 KBborisson_

Comments

saranya purushothaman created an issue. See original summary.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Version: 8.x-1.0-alpha11 » 8.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new uuid_null_on-2911763-2.patch1.08 KB

This should be a solution, not sure if it's the best solution. Note that this only works for creating new sources.

cato’s picture

cato commented
StatusFileSize
new uuid_null_on-2911763-3.patch2.95 KB

Rerolled against latest dev. Changed the UUID to use dependency injection.

Status: Needs review » Needs work

The last submitted patch, 3: uuid_null_on-2911763-3.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented 
+++ b/src/Form/FacetSourceEditForm.php
@@ -26,30 +27,41 @@ class FacetSourceEditForm extends EntityForm {
-   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
+   * @param \Drupal\Core\Entity\EntityTypeManagerInterface        $entity_type_manager
...
-   * @param \Drupal\Core\Extension\ModuleHandlerInterface $moduleHandler
+   * @param \Drupal\Core\Extension\ModuleHandlerInterface         $moduleHandler
...
+   * @param \Drupal\Component\Uuid\UuidInterface                  $uuid

This alignment is not in line with drupal's coding standards. It also leads to unrelated stuff in diffs (as seen in this patch). Could you change it back to just having one space?

cato’s picture

cato commented
StatusFileSize
new uuid_null_on-2911763-6.patch2.57 KB

@borisson roger that. Updated code style.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

Awesome, thanks!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks @cato!

  • borisson_ committed 5025ba0 on 8.x-1.x authored by cato 
    Issue #2911763 by cato, borisson_: UUID null on config-export

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.