Closed (fixed)
Project:
Content locking (anti-concurrent editing)
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Sep 2017 at 15:41 UTC
Updated:
9 Nov 2017 at 12:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hchonovComment #4
kfritscheTranslation lock should only be available if conflict module exists or similar functionality is implemented in core.
Till then only enable this option if conflict is enabled. Otherwise user will have conflicts again or thinks this resolution is already provided by this module.
Comment #6
kfritscheThis should fix the current tests.
New tests would be nice, but not sure if I get to it soon :/
Comment #8
kfritscheFixing test and doing some coding standards love.
Comment #9
hchonovThis totally makes sense!
The patch looks pretty sweet now :). Thank you, @kfritsche!
Comment #10
hchonovI think the patch is ready. Let's see what the module maintainers think about this.
Comment #11
chr.fritschThis was removed in #2912023: Show the lock message after form rebuld.
Everything else looks good to me. Will test it now
Comment #12
hchonovOuch ... good catch!
Comment #13
kfritscheOh, forgot to merge 8.x-1.x into my dev branch again.
Fixed this now. Also fixed an issue that entity_operations are not working anymore.
Comment #14
chr.fritschThat's not possible here
Comment #15
hchonovCould you please explain why it is not possible?
Comment #16
chr.fritsch$this is not allowed. We are not in object context here
Comment #17
kfritscheAnd thats why we have reviews ;)
Thanks a lot.
Fixed #14
Comment #18
kfritscheComment #19
chr.fritschIt seems that it doesn't work for me.
What i did:
Comment #20
hchonovIf you've activated translation lock for the node entity type in the content lock settings, then after those steps only the edit form for the default language should be still locked and the edit form for the new translation language should not contain any lock. If this is what you mean by
then it works as designed. If however the lock is present for the new translation as well could you please ensure that you've enabled translation lock for the node entity type in the content lock settings?
Comment #21
chr.fritschOk, it was my fault. Seems to work. Very nice
Comment #23
chr.fritschThank you. Thats a very nice feature
Comment #24
hchonovThank you for accepting it!
Comment #25
chr.fritschDamn, i think we missed an update hook, because we changed the schema.
Comment #26
hchonovWell there is no release, just an alpha version :). But if you think that it is necessary then we'll have to update the sql table schema. Should we instead introduce only one update for the language column and for the form operation column being introduced by #2916747: Consider the form operation when locking?
Comment #27
chr.fritschWe have 1500 installations, we need an update hook. I am fine with adding it to #2916747: Consider the form operation when locking