Move all entity type REST tests to the providing modules

For reasons that have not yet been full clarified, the massive flow of rest tests is not very stable on CI. Shuffle tests increases stability and reduces execution time in twice (#2926309-18: Random fail due to APCu not being able to allocate memory). It seems to me, that this issue will give the same improve effect, therefore it will be very helpful check the result in a faster way. Sorry if it violates someone's plans, now the issue is not assigned, but CI is on fire.

Patch contains #10 + #11 + other tests.

#17: incorrect patch :(

I made a mistake in calculations, tests are still quite close to each other :| Okay, will find something else)

Few questions by current patch:

1. +++ b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDateonlyTest.php
   @@ -7,8 +7,8 @@
   +use Drupal\Tests\entity_test\Functional\Rest\EntityTestResourceTestBase;
   ...
   -use Drupal\Tests\rest\Functional\EntityResource\EntityTest\EntityTestResourceTestBase;
   
   +++ b/core/modules/datetime/tests/src/Functional/EntityResource/EntityTest/EntityTestDatetimeTest.php
   @@ -7,8 +7,8 @@
   +use Drupal\Tests\entity_test\Functional\Rest\EntityTestResourceTestBase;
   ...
   -use Drupal\Tests\rest\Functional\EntityResource\EntityTest\EntityTestResourceTestBase;
   

   This is an external error. Should we preserve the old classes like wrappers for BC?

2. +++ b/core/modules/views/tests/src/Functional/Rest/ViewXmlCookieTest.php
   similarity index 71%
   rename from core/modules/hal/tests/src/Functional/EntityResource/BaseFieldOverride/BaseFieldOverrideHalJsonAnonTest.php
   
   rename from core/modules/hal/tests/src/Functional/EntityResource/BaseFieldOverride/BaseFieldOverrideHalJsonAnonTest.php
   rename to core/tests/Drupal/Tests/Core/Functional/Hal/BaseFieldOverrideHalJsonAnonTest.php
   

   core/tests/Drupal/Tests/Core/Functional - is this the right location for the test?

@Wim Leers, help us please in #2930022: Testing fails 'CI aborted' and 'apcu memory' 🙏

We found that the rest-tests very strongly stop the CI. Although we have created a non-rest-patch that also adversely affects CI, it is not yet possible to pinpoint the cause of all ills. Maybe you'll have some great idea about this.

#2930022 is still contains a number of puzzles that have yet to be solved. But the main problem of random apcu fail was while resolved via #2926309: Random fail due to APCu not being able to allocate memory, continued #2934002: APCu cache backend can have unreasonable number of entries during testing or multi-site. (Although I do not yet understand why, the random order of the tests and I/O blocked regim were so good for speed and stable. 🔮)

But now there are no specific assumptions that could delay us here. So let's continue.

#20 contains 1 CS error (good for a novice, and NW for this), and 2 questions (presumably for @Wim Leers):

1. Can we just move classes without leaving stubs behind them? Because some tests (like EntityTestDateonlyTest and EntityTestDatetimeTest) can rely on prev namespaces.

2. Are the tests correctly moved? I could be mistaken in some of them. Example

From:
core/modules/hal/tests/src/Functional/EntityResource/BaseFieldOverride/BaseFieldOverrideHalJsonAnonTest.php
To:
core/tests/Drupal/Tests/Core/Functional/Hal/BaseFieldOverrideHalJsonAnonTest.php
This movement is suitable for our test coverage. I also do not see anything wrong with this. But it requires a more experienced review.

Reroll done.

Also about #25.1 question. Probably the tests do not fall under the rigid BC policy. Or we can leave stubs only for the base classes like *ResourceTestBase. If we do the stubs for all tests, it will give a very massive duplication for the test runs on the DI.

My bad. One more attempt.

TL;DR; We need:

1. Reroll #28. Just update in patch MediaResourceTestBase to:

<?php
 
-namespace Drupal\Tests\rest\Functional\EntityResource\Media;
+namespace Drupal\Tests\media\Functional\Rest;
 
 use Drupal\Component\Utility\NestedArray;
 use Drupal\Core\Url;

2. Fix error #31: add to EntityTestTextItemNormalizerTest line:
use Drupal\Tests\entity_test\Functional\Rest\EntityTestResourceTestBase;

3. Fix CS typo in ConfigTestHalJsonCookieTest: remove double ';;' in line:
use Drupal\Tests\rest\Functional\CookieResourceTestTrait;;

💡 The task of issue is to move the tests from the folder core/modules/rest/tests/src/Functional/EntityResource/ to folders with target modules.

🎓 #10 / #11: @Wim Leers showed how to do this (and check).

📌 #17 - #20: I jumped, and laid out an almost ready patch.

🔞 This might not seem entirely ethical, since it was intended for Novice, and it was already taken for CSKyiv18 (by the way, it seems there with him did not work, so let's delete this tag). But I did it because sometimes I just can not resist the temptation of credits. And because I hoped that this would help to solve another problem, because of which the DI was on fire. Unfortunately, this did not help (or not help enough), and I switched to the further search.

☑️ Only CS nit left after #17. We hoped that one of the novice hero would help solve it.

⌛ #28 I did an unsuccessful reroll, and now one more little mistake was added. Therefore, the hope for the novices remained.

⚔️ #35: @ShawnB did a tremendous job from scratch, because unfortunately he misread IS.

🎓#36: @benjifisher explained the necessary corrections, but apparently he was not heard.

Today another reroll also is needed (see 1 point from TL;DR; part).

Here #28 reroll.

@ShawnB, nice catch!

#42: Looks like 2 interdiff patches. Also, the interdiff does not contain fixes for #39.2, #39.3. If you have a desire to help them too?

Thank you, @ShawnB! Merged 3 commits (#41 + #42 + #44).

Thank you, @Wim Leers!

#47: Sounds logical as always. I did this by using the following fraud:

Open the patch in the text editor and run Find/Replace:

core/tests/Drupal/Tests/Core/Functional/
core/tests/Drupal/FunctionalTests/
...
namespace Drupal\Tests\Core\Functional\
namespace Drupal\FunctionalTests\
...
use Drupal\Tests\Core\Functional\
use Drupal\FunctionalTests\

After that, a little edited EntityResourceRestTestCoverageTest.

Let's see how the test bot reacts.

Done :)

opps, unfortunate misprint - no 'dot' in trigger_error

use Drupal\Tests\comment\Functional\Hal\CommentHalJsonTestBase See
                                                              ^

I already fixed it locally. Are there any ideas about the alias class name?
use Drupal\...\CommentHalJsonTestBase as CommentHalJsonTestBaseOriginal;
Maybe better 'Actual' instead of 'Original'?

Real is the best!

#56 need reroll after #2572613: Fix 'Drupal.Array.Array.CommaLastItem' coding standard (Done via #48 + #56 script).

#57: Why not in the 8.5.x? Usually we do conversion in both releases. But in any case, no problem.

Or are you saying that in 8.5 you would essentially like to see the same patch but without the @deprecated?

Great idea. Also I bet that in most cases the changes will be made in the base classes, since they are the heart of the tests.

🚀🚀🚀

Although I will miss this thick EntityTest folder :)

Ohh, one nit for 8.6.x (8.5.x ok)!

🙏🏻 Thanks @Wim Leers and @alexpott! You are great men! ⭐

Follow-up.