Vote Up/Down creates Vote entities with type 'points' (see Drupal\vud\Controller\VotingApiController->vote()). But this vote type is never created by the module. The default vote type created by Drupal 8 version of VotingAPI module has id 'vote', not 'points'. You can see the list of all vote types on page /admin/structure/vote-types.
So I think the module should either:
- Create a new vote type on installation
- Or use the default vote type.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2910822-use-configured-vote-type-4.patch | 2.83 KB | chertzog |
Comments
Comment #2
marvil07 commentedI would say, let's create it at install time, patches are welcome.
Comment #3
chertzogThere is already a configuration form for setting the vote tag located at /admin/config/search/voteupdown, so why not use it.
Comment #4
chertzogUpdated the patch for the widget values.
Comment #5
drupalgin commentedI run test from patch
Comment #7
marvil07 commented@chertzog, thanks for the patch!
Indeed, that is right, we should use our configuration option.
Now added to 8.x-1.x.
Comment #8
drupalgin commented@marvil07 hello.
The patch did not pass automatic tests. Now the module does not pass automatic tests. This needs to be corrected
Comment #9
drupalgin commentedComment #10
marvil07 commented@drupalgin, thanks for trying to help here!
Yes, patch did not pass tests, but the branch itself has not been passing for some time now, so I would say this patch is not the cause.
Help is welcome to fix the test problem on the ticket about it, #2902455: Error on VoteUpDownWidgetManagerTest test.
Moving status back to the previous state.