Vote Up/Down creates Vote entities with type 'points' (see Drupal\vud\Controller\VotingApiController->vote()). But this vote type is never created by the module. The default vote type created by Drupal 8 version of VotingAPI module has id 'vote', not 'points'. You can see the list of all vote types on page /admin/structure/vote-types.

So I think the module should either:
- Create a new vote type on installation
- Or use the default vote type.

CommentFileSizeAuthor
#4 2910822-use-configured-vote-type-4.patch2.83 KBchertzog
#3 2910822-use-configured-vote-type.patch1.75 KBchertzog

Comments

codeyourdream created an issue. See original summary.

marvil07’s picture

marvil07 commented

I would say, let's create it at install time, patches are welcome.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Active » Needs review
StatusFileSize
new 2910822-use-configured-vote-type.patch1.75 KB

There is already a configuration form for setting the vote tag located at /admin/config/search/voteupdown, so why not use it.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
StatusFileSize
new 2910822-use-configured-vote-type-4.patch2.83 KB

Updated the patch for the widget values.

drupalgin’s picture

drupalgin commented

I run test from patch

  • marvil07 committed c74b8d5 on 8.x-1.x authored by chertzog 
    Issue #2910822 by chertzog: Use the configured vote type
marvil07’s picture

marvil07 commented
Status: Needs review » Fixed

@chertzog, thanks for the patch!
Indeed, that is right, we should use our configuration option.
Now added to 8.x-1.x.

drupalgin’s picture

drupalgin commented

@marvil07 hello.

The patch did not pass automatic tests. Now the module does not pass automatic tests. This needs to be corrected

drupalgin’s picture

drupalgin commented
Status: Fixed » Needs work
marvil07’s picture

marvil07 commented
Status: Needs work » Fixed

@drupalgin, thanks for trying to help here!

Yes, patch did not pass tests, but the branch itself has not been passing for some time now, so I would say this patch is not the cause.

Help is welcome to fix the test problem on the ticket about it, #2902455: Error on VoteUpDownWidgetManagerTest test.

Moving status back to the previous state.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.