The messages generated by Drupal about image resizing are often incomprehensible for many users. This patch improves the messages, including specifying image sizes affected by errors.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | image-resizing-messaging.png | 197.15 KB | dani3lr0se |
| #10 | interdiff-2909676-8-10.txt | 1.42 KB | rang501 |
| #10 | 2909676-10.patch | 5.33 KB | rang501 |
| #8 | 2909676-8.patch | 3.77 KB | jofitz |
| #5 | Improve_image_messages_about_resizing.png | 97.93 KB | Miraya |
Comments
Comment #2
th_tushar commentedComment #3
Miraya commentedWorking on this now at DC Vienna.
Comment #4
mradcliffeThis would probably need a re-roll for 8.5.x as this is a string change and we're in 8.4.x RC phase.
Added the Needs issue summary update tag so that we can expand out the proposed resolution and maybe some screenshots.
Comment #5
Miraya commentedOriginal patch applies fine to 8.5.x.
Changed grammar to make things more clear (see screenshot). Thank to Amber Himes Matz for grammar checking!
Comment #6
Miraya commentedComment #8
jofitzBoth patches (in #1 and #5) were based on the wrong directory.
Re-rolled patch from #5.
Comment #10
rang501 commentedTried to fix the failed test.
Comment #11
dani3lr0se commentedI tested with simplytest.me on 8.5.x-dev and can confirm that the patch works. Please see attached screenshot to see that the message displays as intended. It looks nice and is easy to understand. I agree that it currently could be displayed a little better, so this will be nice to see. Thanks for the patch. :)
Comment #12
xjmThese messages do indeed seem clearer. Thanks for working on this and for the screenshots in #5 and #11.
Since the patch is a user interface improvement that includes some string changes, I committed it to 8.5.x only. Thanks!