The messages generated by Drupal about image resizing are often incomprehensible for many users. This patch improves the messages, including specifying image sizes affected by errors.

CommentFileSizeAuthor
#11 image-resizing-messaging.png197.15 KBdani3lr0se
#10 interdiff-2909676-8-10.txt1.42 KBrang501
#10 2909676-10.patch5.33 KBrang501
#8 2909676-8.patch3.77 KBjofitz
#5 Improve_image_messages_about_resizing.png97.93 KBMiraya
#5 Improve_image_messages_about_resizing.patch3.71 KBMiraya
#5 interdiff-2909676-1-5.txt2.92 KBMiraya
Improve_image_messages_about_resizing.patch3.68 KBericbellot
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericbellot created an issue. See original summary.

th_tushar’s picture

th_tushar CreditAttribution: th_tushar commented
Issue tags: +Vienna2017, +Novice
Miraya’s picture

Miraya CreditAttribution: Miraya commented

Working on this now at DC Vienna.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
CreditAttribution: mradcliffe at Kosada commented
Version: 8.4.x-dev » 8.5.x-dev
Issue tags: +Needs issue summary update, +Needs reroll

This would probably need a re-roll for 8.5.x as this is a string change and we're in 8.4.x RC phase.

Added the Needs issue summary update tag so that we can expand out the proposed resolution and maybe some screenshots.

Miraya’s picture

Miraya CreditAttribution: Miraya commented
FileSize
interdiff-2909676-1-5.txt2.92 KB
Improve_image_messages_about_resizing.patch3.71 KB
Improve_image_messages_about_resizing.png97.93 KB

Original patch applies fine to 8.5.x.
Changed grammar to make things more clear (see screenshot). Thank to Amber Himes Matz for grammar checking!

Miraya’s picture

Miraya CreditAttribution: Miraya commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 5: Improve_image_messages_about_resizing.patch, failed testing. View results

jofitz’s picture

jofitz CreditAttribution: jofitz at ComputerMinds commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
FileSize
2909676-8.patch3.77 KB

Both patches (in #1 and #5) were based on the wrong directory.

Re-rolled patch from #5.

Status: Needs review » Needs work

The last submitted patch, 8: 2909676-8.patch, failed testing. View results

rang501’s picture

rang501 CreditAttribution: rang501 at ADM Interactive commented
Status: Needs work » Needs review
FileSize
2909676-10.patch5.33 KB
interdiff-2909676-8-10.txt1.42 KB

Tried to fix the failed test.

dani3lr0se’s picture

dani3lr0se CreditAttribution: dani3lr0se at Hook 42 commented
Status: Needs review » Reviewed & tested by the community
FileSize
image-resizing-messaging.png197.15 KB

I tested with simplytest.me on 8.5.x-dev and can confirm that the patch works. Please see attached screenshot to see that the message displays as intended. It looks nice and is easy to understand. I agree that it currently could be displayed a little better, so this will be nice to see. Thanks for the patch. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +String change in 8.5.0

These messages do indeed seem clearer. Thanks for working on this and for the screenshots in #5 and #11.

Since the patch is a user interface improvement that includes some string changes, I committed it to 8.5.x only. Thanks!

  • xjm committed c9678f5 on 8.5.x 
    Issue #2909676 by Miraya, rang501, ericbellot, Jo Fitzgerald,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.