After enabling advagg CDN, I cannot get Views UI modals to open anymore. Disabling the module resolves the problem. I am getting hte following error in the logs:
Warning: ksort() expects parameter 1 to be array, null given in Drupal\Core\Asset\JsCollectionGrouper->group() (line 34 of /home/d2ly0/www/core/lib/Drupal/Core/Asset/JsCollectionGrouper.php) #0 /home/d2ly0/www/core/includes/bootstrap.inc(566): _drupal_error_handler_real(2, 'ksort() expects...', '/home/d2ly0/www...', 34, Array) #1 [internal function]: _drupal_error_handler(2, 'ksort() expects...', '/home/d2ly0/www...', 34, Array) #2 /home/d2ly0/www/core/lib/Drupal/Core/Asset/JsCollectionGrouper.php(34): ksort(NULL) #3 /home/d2ly0/www/core/lib/Drupal/Core/Asset/JsCollectionOptimizer.php(76): Drupal\Core\Asset\JsCollectionGrouper->group(Array) #4 /home/d2ly0/www/core/lib/Drupal/Core/Asset/AssetResolver.php(297): Drupal\Core\Asset\JsCollectionOptimizer->optimize(Array) #5 /home/d2ly0/www/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php(298): Drupal\Core\Asset\AssetResolver->getJsAssets(Object(Drupal\Core\Asset\AttachedAssets), true) #6 /home/d2ly0/www/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php(161): Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAssetLibraries(Object(Drupal\Core\Asset\AttachedAssets), Array) #7 /home/d2ly0/www/core/lib/Drupal/Core/EventSubscriber/HtmlResponseSubscriber.php(45): Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments(Object(Drupal\Core\Render\HtmlResponse)) #8 /home/d2ly0/www/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(108): Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond(Object(Symfony\Component\HttpKernel\Event\FilterResponseEvent), 'kernel.response', Object(Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher)) #9 /home/d2ly0/www/vendor/symfony/http-kernel/HttpKernel.php(193): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch('kernel.response', Object(Symfony\Component\HttpKernel\Event\FilterResponseEvent)) #10 /home/d2ly0/www/vendor/symfony/http-kernel/HttpKernel.php(175): Symfony\Component\HttpKernel\HttpKernel->filterResponse(Object(Drupal\Core\Render\HtmlResponse), Object(Symfony\Component\HttpFoundation\Request), 1) #11 /home/d2ly0/www/vendor/symfony/http-kernel/HttpKernel.php(68): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #12 /home/d2ly0/www/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #13 /home/d2ly0/www/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #14 /home/d2ly0/www/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #15 /home/d2ly0/www/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #16 /home/d2ly0/www/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #17 /home/d2ly0/www/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #18 /home/d2ly0/www/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #19 /home/d2ly0/www/core/lib/Drupal/Core/DrupalKernel.php(656): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #20 /home/d2ly0/www/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #21 {main}.
I just noticed this is a similar error as the one I am getting in #2901491: Advagg CDN not compatible with Geolocation Field, so I suppose they have the same cause.
Comments
Comment #2
neograph734Comment #3
nickdickinsonwildeThanks for the report. I'll try and get it in next release, (will also be looking at the geo-location field, haven't had a chance yet)
Comment #4
neograph734Thanks Nick,
Drop me a note if you need me to test something.
Comment #5
nickdickinsonwildeOddly, I haven't managed to reproduce this.
Despite that, I think I *may* have fixed it (in #2888869: Error in function JsCollectionRenderer->render() after enabling module), could you try the latest dev release?
Comment #6
nickdickinsonwildeActually... I did find a problem/bug.
Hadn't updated the version that the cdn was by default selecting, however, Drupal core had updated and in some cases that was causing problems. I'm not 100% sure that is this issue, but it is a issue, I've committed that fix and hopefully it does fix this issue. If you could give it a test (just use the latest dev version and run the db updates - through drupal update:execute or drush updb or the UI, any will work fine)
Comment #8
neograph734Hi Nick, I have tested this with a stable Drupal 8.4 installation and the views modals work again. (Switching to fixed as you have already committed.)
Comment #9
nickdickinsonwildeAwesome. Thanks so much for the reports and testing (also great to know that it fixed the other issue 😀)