Updated to rc1 and get the following error:

The website encountered an unexpected error. Please try again later.
ParseError: syntax error, unexpected ';', expecting ',' or ')' in Composer\Autoload\includeFile() (line 103 of [...]/web/modules/contrib/redis/src/ClientFactory.php).

The row is missing a ")".

$settings = Settings::get('redis.connection', [];

Same with line 147.

Another missing ")" in CacheBase.php, line 135.

CommentFileSizeAuthor
#7 syntax_error_2908741-1.patch1.53 KBdtv_rb

Comments

dtv_rb created an issue. See original summary.

dtv_rb’s picture

dtv_rb commented
Issue summary: View changes
dtv_rb’s picture

dtv_rb commented
Issue summary: View changes
dtv_rb’s picture

dtv_rb commented

Search and replace from old array syntax to new one without testing afterwards ;)?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yeah, that's the problem when you can't run tests on d.o ;)

Patch welcome, will commit asap and do a new release.

slowflyer’s picture

slowflyer commented

Same error in:

/src/ClientFactory.php on line 147
/src/Cache/CacheBase.php, line 135

dtv_rb’s picture

dtv_rb commented
StatusFileSize
new syntax_error_2908741-1.patch1.53 KB

Here is a patch. Please test it before release.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Active » Reviewed & tested by the community

Can confirm patch works and no syntax error afterwards.

  • Berdir committed c03262b on 8.x-1.x authored by dtv_rb 
    Issue #2908741 by dtv_rb: Syntax Error in ClientFactory.php
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Yes, also confirmed to pass the tests on github this time. Sorry about that :)

dtv_rb’s picture

dtv_rb commented

Glad I could help! :) Big respect for your work @Berdir!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.