Hi,

If somehow variable_get('site_mail') falls back to the default value, we end up directing possible bounceback spam at a *real* email address on the noadmin.com home page. By changing it to example.com, we let any bounces get dropped to the bit bucket.

Or perhaps a better solution - why not just determine the site domain, and append webmaster@?

--Andrew

CommentFileSizeAuthor
noadmin.patch1.22 KBdeviantintegral

Comments

dww’s picture

dww
we/he/they
commented
Title: Change noadmin.com to example.com for default site_mail » Use ini_get('sendmail_from') for default site_mail
Category: bug » task

Good one, thanks. Committed to HEAD, backported to DRUPAL-5, and committed there, too.

What core does is uses this:

variable_get('site_mail', ini_get('sendmail_from'));

We should probably just do the same. If you agree, don't bother with a patch, I can just make the change.

deviantintegral’s picture

deviantintegral commented

Using ini_get sounds good to me.

--Andrew

dww’s picture

dww
we/he/they
commented
Category: task » bug
Status: Active » Fixed

Hrm, except it's possible for ini_get('sendmail_from') to come up empty. I don't know if it's worth even more code, since core doesn't care about this case. Oh well, I think Be Like Core(tm) is going to win here, so I committed to HEAD and DRUPAL-5. ;)

Oh, and the old bogus use of "noadmin.com" was definitely a bug.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

rishish’s picture

rishish commented

is it a built in function..??

rishish’s picture

rishish commented

is there any way to use it in settings.php.
From where this function is exactly written.