API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

> string $entity_type: The entity type.

Should say 'entity type ID'. The type is an object, the ID is a string.

CommentFileSizeAuthor
#6 interdiff-6-8.txt879 bytesbramdriesen
#6 2907282-6.patch2.31 KBbramdriesen
#2 2907282-2.patch2.31 KBbramdriesen

Comments

joachim created an issue. See original summary.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Category: Bug report » Task
Status: Active » Needs review
StatusFileSize
new 2907282-2.patch2.31 KB

Patch attached with the documentation change.

amateescu’s picture

amateescu commented
Status: Needs review » Reviewed & tested by the community

Looks fine :)

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/lib/Drupal/Core/Entity/EntityTypeBundleInfoInterface.php
@@ -21,8 +21,8 @@ public function getAllBundleInfo();
+   * @param string $entity_type_id_id
+   *   The entity type ID.

@@ -30,7 +30,7 @@ public function getAllBundleInfo();
-  public function getBundleInfo($entity_type);
+  public function getBundleInfo($entity_type_id_id);

Probably not? (_id_id).

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: Unassigned » bramdriesen

Indeed, will upload a new patch for this.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new 2907282-6.patch2.31 KB
new interdiff-6-8.txt879 bytes

Patch and interdiff attached. Good catch!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: bramdriesen » Unassigned
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • catch committed e00e9cb on 8.5.x 
    Issue #2907282 by BramDriesen, joachim: EntityTypeBundleInfoInterface::...

  • catch committed c898ff5 on 8.4.x 
    Issue #2907282 by BramDriesen, joachim: EntityTypeBundleInfoInterface::...
catch’s picture

catch
he/him
Primary language English
commented
Version: 8.5.x-dev » 8.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.5.x, and cherry-picked to 8.4.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.