One Column Layout

This is actually by design. In your example you can see the body text will stretch if there is no sidebar. Some people might argue the text becomes less readable. Also media size like images and videos could grow both in width and height with all kinds of unpredictable behaviour. I am not saying there aren't solutions for that. But for now it is safer to have a fixed with for content / streams / overviews and not be depending on block placement.

I think it would be a good idea to add a feature to force a 1-column layout. But I am not sure yet what or where should trigger this. It should not only work for a developer but easy to maintain for site manager roles as well.

For now if you want to use your approach you can use the patch.

I have tested with your patches. I think we should cater for such an one column layout indeed, but this change will now change too much for existing installs and I don't feel confident making this change now without any settings for a SM. I want to take a bit more time and see what is good for forms (can be full width) and compare it to a page display (which should be centered and get a maximum width). Also give some control via the UI.

Hi guys,
my idea is to move all classes to preprocess function,
user will be able to change classes in own theme like this:

use Drupal\Core\Template\Attribute;

function THEME_preprocess_page(&$variables){

  if ($variables['content_attributes'] instanceof Attribute) {
    if (SOME_CONDITION) {
      $variables['content_attributes']->removeClass('layout--with-complementary')
    }
  }
}

will it work?

Patch updated, now <section> is in twig block.

This change has been merged in develop and will be part of release 1.7.
There are two methods present:

- You can extend the template and override the section twig block
- You can manipulate the classes via theme_preprocess_page function (preferred method is to extend the Page class)

Thanks for the heads up. Volodymyr has created a new commit with the changes. Now all logic is tested and works. Just waiting for the automated tests to pass and then I will merge and close the issue.

The code in socialbase/src/Plugin/Preprocess/Page.php is still not working correctly.

I have tested with a basic page without blocks in the complementary regions and not in the sidebars.

The following code does not work:

if (empty($variables['page']['complementary_top']) && empty($variables['page']['complementary_bottom'])) {
      if ($variables['page']['sidebar_first'] && $variables['page']['sidebar_second']) {
        $attributes->addClass('layout--with-three-columns');
      }
      if (!empty($variables['page']['sidebar_second']) xor !empty($variables['page']['sidebar_first'])) {
        $attributes->addClass('layout--with-two-columns');
      }
    }

i did some testing and it appears that the complementary_top and complementary_bottom variables are never seen as empty, even if there are not blocks in those regions.

hi
On my own side i hidden "Primary admin actions" block the region looks to not be displayed anymore but the content region doesn't automatically set to full width.

what should i do please ?