False positives are raised for Drupal.Commenting.FunctionComment.InvalidNoReturn when yield is used.

Comments

mfernea created an issue. See original summary.

mfernea’s picture

mfernea commented
Status: Active » Needs review

Here is the pull request: https://github.com/pfrenssen/coder/pull/8

mfernea’s picture

mfernea commented

The test is failing on PHP 5.4 because yield was introduced in PHP 5.5 and PHPCS_T_YIELD is not available hence T_YIELD is not available too. I don't know how to fix this.

  • klausi committed 44c80c2 on 8.x-3.x authored by mfernea 
    fix(FunctionComment): Recognise 'yield' as valid return statement (#...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 8.x-2.x-dev » 8.x-3.x-dev
Status: Needs review » Fixed

Committed, thanks!

  • klausi committed 303046e on 8.x-2.x 
    Revert "fix(FunctionComment): Recognise 'yield' as valid return...
  • klausi committed f5757e5 on 8.x-2.x authored by mfernea
    fix(FunctionComment): Recognise 'yield' as valid return statement (#...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.